Merge lp://qastaging/~bogdana/landscape-client/mocker-test-service into lp://qastaging/~landscape/landscape-client/trunk

Proposed by Bogdana Vereha
Status: Merged
Approved by: Bogdana Vereha
Approved revision: 843
Merged at revision: 844
Proposed branch: lp://qastaging/~bogdana/landscape-client/mocker-test-service
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 38 lines (+10/-8)
1 file modified
landscape/broker/tests/test_service.py (+10/-8)
To merge this branch: bzr merge lp://qastaging/~bogdana/landscape-client/mocker-test-service
Reviewer Review Type Date Requested Status
Bogdana Vereha (community) Approve
Данило Шеган (community) Approve
Chad Smith Approve
Review via email: mp+297482@code.qastaging.launchpad.net

Commit message

Port broker.test_service.
This test used to just hang (timeout?) instead of failing before, so just checking if the methods were called seemed like a better way.

Description of the change

Port broker.test_service.
This test used to just hang (timeout?) instead of failing before, so just checking if the methods were called seemed like a better way.

Testing instructions:
Unit tests

To post a comment you must log in.
Revision history for this message
Chad Smith (chad.smith) wrote :

+1 rock!

review: Approve
Revision history for this message
Данило Шеган (danilo) wrote :

Looks good, fails when calls are removed from BrokerService methods.

review: Approve
Revision history for this message
Bogdana Vereha (bogdana) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: