Landscape Client

Merge lp://qastaging/~bogdana/landscape-client/remove-mocker-test-service into lp://qastaging/~landscape/landscape-client/trunk

  1. remove-mocker-test-service
  2. Merge into trunk
Proposed by Bogdana Vereha
Status: Merged
Approved by: Bogdana Vereha
Approved revision: 846
Merged at revision: 846
Proposed branch: lp://qastaging/~bogdana/landscape-client/remove-mocker-test-service
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 28 lines (+4/-4)
1 file modified
landscape/tests/test_service.py (+4/-4)
To merge this branch: bzr merge lp://qastaging/~bogdana/landscape-client/remove-mocker-test-service
Reviewer Review Type Date Requested Status
🤖 Landscape Builder test results Approve
Benji York (community) Approve
Free Ekanayaka (community) Approve
Review via email: mp+297491@code.qastaging.launchpad.net

Commit message

Update landscape.tests.test_service to use mock.

Description of the change

Update landscape.tests.test_service

Testing instructions:
Unit tests

To post a comment you must log in.
Revision history for this message
Free Ekanayaka (free.ekanayaka) :
review: Needs Fixing
Revision history for this message
Bogdana Vereha (bogdana) wrote :

Thanks, updated.

Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

+1

review: Approve
Revision history for this message
Benji York (benji) wrote :

This looks good. I had one inline comment.

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make check
Result: Success
Revno: 845
Branch: lp:~bogdana/landscape-client/remove-mocker-test-service
Jenkins: https://ci.lscape.net/job/latch-test/5032/

review: Approve (test results)
lp://qastaging/~bogdana/landscape-client/remove-mocker-test-service updated
846. By Bogdana Vereha

Use assert_called_once_with instead of called_with

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: