Merge lp://qastaging/~bogdana/landscape-client/save-aptsources into lp://qastaging/~landscape/landscape-client/trunk
Status: | Merged |
---|---|
Approved by: | Bogdana Vereha |
Approved revision: | 932 |
Merged at revision: | 929 |
Proposed branch: | lp://qastaging/~bogdana/landscape-client/save-aptsources |
Merge into: | lp://qastaging/~landscape/landscape-client/trunk |
Diff against target: |
251 lines (+124/-62) 2 files modified
landscape/manager/aptsources.py (+24/-23) landscape/manager/tests/test_aptsources.py (+100/-39) |
To merge this branch: | bzr merge lp://qastaging/~bogdana/landscape-client/save-aptsources |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
🤖 Landscape Builder | test results | Approve | |
Alberto Donato (community) | Approve | ||
Adam Collard (community) | 🚴 | Abstain | |
Данило Шеган (community) | Approve | ||
Review via email: mp+313608@code.qastaging.launchpad.net |
Commit message
Save the original sources.list file when a repository profile is associated with a computer and restore it when the profile is removed.
Description of the change
Save the original sources.list file when a repository profile is associated with a computer and restore it when the profile is removed.
Note: this changed was based on the assumption that when a profile is removed or computer is disassociated, the server sends an apt-sources-replace message with an empty sources list (and that's the only case when this happens)
Testing instructions:
1. Follow the instructions in the linked bug to create a repository profile and associate a tag to it
2. Tag a computer that runs the updated version of the landscape client
3. Check that a sources.list.save file was created
4. Untag the computer
5. Check that the original contents of the sources.list file were restored
Command: TRIAL_ARGS=-j4 make check /ci.lscape. net/job/ latch-test- precise/ 842/
Result: Success
Revno: 925
Branch: lp:~bogdana/landscape-client/save-aptsources
Jenkins: https:/