Landscape Client

Merge lp://qastaging/~bogdana/landscape-client/swift-reporting into lp://qastaging/~landscape/landscape-client/trunk

  1. swift-reporting
  2. Merge into trunk
Proposed by Bogdana Vereha
Status: Merged
Approved by: Bogdana Vereha
Approved revision: 845
Merged at revision: 840
Proposed branch: lp://qastaging/~bogdana/landscape-client/swift-reporting
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 39 lines (+20/-1)
2 files modified
landscape/monitor/swiftusage.py (+1/-1)
landscape/monitor/tests/test_swiftusage.py (+19/-0)
To merge this branch: bzr merge lp://qastaging/~bogdana/landscape-client/swift-reporting
Reviewer Review Type Date Requested Status
Данило Шеган (community) Approve
Adam Collard (community) Approve
Review via email: mp+290960@code.qastaging.launchpad.net

Commit message

Fix device enconding for swiftusage.

Description of the change

Fix device enconding for swiftusage according to Andreas' last comment in the bug.

To post a comment you must log in.
Revision history for this message
Adam Collard (adam-collard) wrote :

Looks good! +1

review: Approve
Revision history for this message
Данило Шеган (danilo) wrote :

FWIW, this is generally wrong. It is a small change and likely smaller than the proper fix in persist module, but please fix it properly once the fires are put down. Otherwise, it'd be an invitation for more quirky bugs.

So, a conditional approve assuming you can also do a (more) proper fix later.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: