Compiz

Merge lp://qastaging/~brandontschaefer/compiz/disable-tap-detection into lp://qastaging/compiz/0.9.9

  1. disable-tap-detection
  2. Merge into 0.9.9
Proposed by Brandon Schaefer
Status: Merged
Approved by: Daniel van Vugt
Approved revision: 3408
Merged at revision: 3408
Proposed branch: lp://qastaging/~brandontschaefer/compiz/disable-tap-detection
Merge into: lp://qastaging/compiz/0.9.9
Diff against target: 119 lines (+34/-5)
4 files modified
include/core/action.h (+2/-1)
src/privatescreen.h (+4/-0)
src/screen.cpp (+18/-4)
xslt/bcop.xslt (+10/-0)
To merge this branch: bzr merge lp://qastaging/~brandontschaefer/compiz/disable-tap-detection
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
jenkins (community) continuous-integration Needs Fixing
Review via email: mp+127370@code.qastaging.launchpad.net

Commit message

Added a new template that will check tap_detection. If it is false then add
CompAction::StateTapIgnore to the actions state.

If StateTapIgnore is set then in grabUngrabManyKeys ignore grabbing all
modifier+<keys>, because we don't care if the modifier is a tap or not.

This allows for Super+P to work with this unity branch:
https://code.launchpad.net/~brandontschaefer/unity/disable-tap-for-super/+merge/127407

Description of the change

See commit message.

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

FAILED: Continuous integration, rev:3407
http://jenkins.qa.ubuntu.com/job/compiz-ci/153/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-ci/./build=pbuilder,distribution=quantal,flavor=amd64/153/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

We should avoid double negatives because they're confusing to read. So:
            <xsl:when test="./disable_tap_detection/text() = 'true'">
should be:
            <xsl:when test="./enable_tap_detection/text() = 'false'">

review: Needs Fixing
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Also, for consistency and clarity DisableTapDetection should be called something else starting with "State..."

Otherwise, it looks good. And tap detection still works as before.

review: Needs Fixing
lp://qastaging/~brandontschaefer/compiz/disable-tap-detection updated
3408. By Brandon Schaefer

* Renamed things

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Alright, renamed some things :) (Hopefully it is descriptive enough!)

Revision history for this message
jenkins (martin-mrazik+qa) wrote :

FAILED: Continuous integration, rev:3408
http://jenkins.qa.ubuntu.com/job/compiz-ci/156/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-ci/./build=pbuilder,distribution=quantal,flavor=amd64/156/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

OK, looks good. And I've retested confirming tap detection still works (when you want it).

review: Approve
Revision history for this message
Michael Terry (mterry) wrote :

I commented in the Unity branch about this too, but I'd like to see a regression test for this. I happened to run into Steve Magoun in Lexington, and he mentioned that this bug had regressed more than once.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches