Merge lp://qastaging/~brandontschaefer/compiz/fix-950160-6.0 into lp://qastaging/compiz/0.9.8

Proposed by Brandon Schaefer
Status: Work in progress
Proposed branch: lp://qastaging/~brandontschaefer/compiz/fix-950160-6.0
Merge into: lp://qastaging/compiz/0.9.8
Diff against target: 119 lines (+34/-5)
4 files modified
include/core/action.h (+2/-1)
src/privatescreen.h (+4/-0)
src/screen.cpp (+18/-4)
xslt/bcop.xslt (+10/-0)
To merge this branch: bzr merge lp://qastaging/~brandontschaefer/compiz/fix-950160-6.0
Reviewer Review Type Date Requested Status
Compiz Maintainers Pending
Review via email: mp+132926@code.qastaging.launchpad.net

Commit message

Added a new template that will check tap_detection. If it is false then add
CompAction::StateTapIgnore to the actions state.

If StateTapIgnore is set then in grabUngrabManyKeys ignore grabbing all
modifier+<keys>, because we don't care if the modifier is a tap or not.

This allows for Super+P to work with this unity branch:
https://code.launchpad.net/~brandontschaefer/unity/disable-tap-for-super/+merge/127407

Description of the change

Added a new template that will check tap_detection. If it is false then add
CompAction::StateTapIgnore to the actions state.

If StateTapIgnore is set then in grabUngrabManyKeys ignore grabbing all
modifier+<keys>, because we don't care if the modifier is a tap or not.

This allows for Super+P to work with this unity branch:
https://code.launchpad.net/~brandontschaefer/unity/disable-tap-for-super/+merge/127407

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

FYI, when ready, I will still be hesitant to land this until it's been tested by a few people in raring. The same goes for backporting anything.

Too many times recently we've backported code that contained regressions. Simply because the backport was rushed in before the changes were fully tested in the development series.

Unmerged revisions

3412. By Brandon Schaefer

* Adds StateIgnoreTap, so you can set a key to not dectect taps (which makes it not XGrab each key+*)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches