Nux

Merge lp://qastaging/~brandontschaefer/nux/poke-lookupstring-SRU into lp://qastaging/nux/2.0

Proposed by Brandon Schaefer
Status: Work in progress
Proposed branch: lp://qastaging/~brandontschaefer/nux/poke-lookupstring-SRU
Merge into: lp://qastaging/nux/2.0
Diff against target: 14 lines (+2/-2)
1 file modified
NuxGraphics/GraphicsDisplayX11.cpp (+2/-2)
To merge this branch: bzr merge lp://qastaging/~brandontschaefer/nux/poke-lookupstring-SRU
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Disapprove
Christopher Townsend (community) Approve
Review via email: mp+182724@code.qastaging.launchpad.net

Commit message

Use a temp buf to poke for the size of string vs passing nullptr. For some reason this was working for most cases, but not greek. Using a temp buf allows us to poke the greeks chars and others that werent working.

Description of the change

Use a temp buf to poke for the size of string vs passing nullptr. For some reason this was working for most cases, but not greek. Using a temp buf allows us to poke the greeks chars and others that werent working.

To post a comment you must log in.
Revision history for this message
Christopher Townsend (townsend) wrote :

LGTM +1

review: Approve
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

This causes a regression!

review: Disapprove

Unmerged revisions

622. By Brandon Schaefer

* Use a temp buff to poke for the size of the char* from the event.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: