Merge lp://qastaging/~brandontschaefer/unity-lens-music/cancellable-search into lp://qastaging/unity-lens-music
Proposed by
Brandon Schaefer
| Status: | Merged |
|---|---|
| Approved by: | Michal Hruby |
| Approved revision: | 74 |
| Merged at revision: | 71 |
| Proposed branch: | lp://qastaging/~brandontschaefer/unity-lens-music/cancellable-search |
| Merge into: | lp://qastaging/unity-lens-music |
| Diff against target: |
138 lines (+17/-21) 4 files modified
src/banshee-scope.vala (+2/-1) src/musicstore-collection.vala (+3/-12) src/musicstore-scope.vala (+3/-2) src/simple-scope.vala (+9/-6) |
| To merge this branch: | bzr merge lp://qastaging/~brandontschaefer/unity-lens-music/cancellable-search |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michal Hruby (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This fixes the problem when you search then delete your search; and the musicstore scope didn't update fast enough but the check for is_empty_
Now musicstore-
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Nice work, I have just one little thing to make it perfect:
8 - int max_results = -1)
9 + int max_results = -1,
10 + Cancellable cancellable)
(and other instances of the same) Please make the Cancellable nullable and null by default (ie -> "Cancellable? cancellable = null")