Unity

Merge lp://qastaging/~brandontschaefer/unity/disable-tap-for-super into lp://qastaging/unity

  1. disable-tap-for-super
  2. Merge into trunk
Proposed by Brandon Schaefer
Status: Rejected
Rejected by: Brandon Schaefer
Proposed branch: lp://qastaging/~brandontschaefer/unity/disable-tap-for-super
Merge into: lp://qastaging/unity
Diff against target: 12 lines (+1/-0)
1 file modified
plugins/unityshell/unityshell.xml.in (+1/-0)
To merge this branch: bzr merge lp://qastaging/~brandontschaefer/unity/disable-tap-for-super
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Review via email: mp+127407@code.qastaging.launchpad.net

Commit message

Disable reliable compiz tap detection for the Super key, so other programs
can still bind to Super+other_keys.
(LP: #950160)

Description of the change

A new option to disable tap detection in compiz. This sets it true for Super/show_launcher key.

Depends on this branch:
https://code.launchpad.net/~brandontschaefer/compiz/disable-tap-detection/+merge/127370

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Looks good to me. But it won't work until you have the requisite compiz change.

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1457/console reported an error when processing this lp:~brandontschaefer/unity/disable-tap-for-super branch.
Not merging it.

Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1466/console reported an error when processing this lp:~brandontschaefer/unity/disable-tap-for-super branch.
Not merging it.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Rejected why?

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Hmm seems to be superseded by:
lp:~brandontschaefer/unity/disable-super-tap-detection

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Sorry I didn't make a comment. This branch has a criss-cross problem, which messes up/confuses the merger. The easiest thing was just to make a new branch :)

Unmerged revisions

2777. By Brandon Schaefer

* Renamed

2776. By Brandon Schaefer

* Disable tap detection for the Super key

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.