Unity

Merge lp://qastaging/~brandontschaefer/unity/fix-860805 into lp://qastaging/unity

fix-860805
Merge into trunk

Proposed by Tim Penhey on 2011-11-29

Status:

Merged

Approved by:

Tim Penhey on 2011-12-05

Approved revision:

no longer in the source branch.

Merged at revision:

1759

Proposed branch:

lp://qastaging/~brandontschaefer/unity/fix-860805

Merge into:

lp://qastaging/unity

Diff against target:

26 lines (+11/-1)

2 files modified

manual-tests/launcher.txt (+11/-0)
plugins/unityshell/src/DashView.cpp (+0/-1)

To merge this branch:

bzr merge lp://qastaging/~brandontschaefer/unity/fix-860805

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Tim Penhey (community)			Approve on 2011-11-30
Review via email: mp+83713@code.qastaging.launchpad.net

Commit message

Fix the dash so it gets keyboard focus the first time.

Revision history for this message

Brandon Schaefer (brandontschaefer) wrote on 2011-11-29:

The problem is in DashController::SetupDashView(). While making the new DashView it calls this "lens_bar_->Activate("home.lens");" which then it gets to this function, "nux::GetWindowCompositor().SetKeyFocusArea(search_bar_->text_entry());" which should set up the key focus so you can type in the search bar.

This function is getting called before "window_->SetLayout(layout)" in DashController::SetupDashView() which causes the first call to SetKeyFocusArea to not work as intended.

So when SetKeyFocus is called in DashController::ShowDash() it just returns instead of setting the key focus. Removing that line of code in DashView allows for everything to finish getting setup; then when SetKeyFocusArea is call it sets that up correctly.

Revision history for this message

Tim Penhey (thumper) wrote on 2011-11-30:

Looks good. We are discussing on IRC the desire for a nux branch for the underlying issue.

review: Approve

Revision history for this message

Tim Penhey (thumper) wrote on 2011-12-05:

Thomi is tasked with writing the autopilot test for thist.