Merge lp://qastaging/~brandontschaefer/unity/lp.1120223-smooth-barrier-break into lp://qastaging/unity
Proposed by
Brandon Schaefer
| Status: | Merged |
|---|---|
| Approved by: | Marco Trevisan (Treviño) |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 3150 |
| Proposed branch: | lp://qastaging/~brandontschaefer/unity/lp.1120223-smooth-barrier-break |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
246 lines (+104/-35) 4 files modified
launcher/Launcher.cpp (+3/-1) launcher/PointerBarrier.cpp (+30/-9) launcher/PointerBarrier.h (+6/-0) tests/test_pointer_barrier.cpp (+65/-25) |
| To merge this branch: | bzr merge lp://qastaging/~brandontschaefer/unity/lp.1120223-smooth-barrier-break |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Marco Trevisan (Treviño) | Approve | ||
| PS Jenkins bot | continuous-integration | Pending | |
|
Review via email:
|
|||
Commit message
Force the first event generated to skip the smoothing timer. This way we can see if we need to release the barrier. Otherwise the mouse hits the barrier for 75ms until the smoothing timer has gone off.
Description of the change
=== Problem ===
There is a 75ms timer in PointerBarrier.cpp which means it won't send the first event until after 75ms, which causes the mouse to get caught a bit on a barrier it should skip.
=== Fix ===
Keep up to date with any new events coming in, as soon as we get a new event id we force the first one through to see if we should release the barrier or not.
=== Test ===
unit test
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
It works well, tests pass.
Thanks! ;)