Unity

Merge lp://qastaging/~brandontschaefer/unity/lp.1267210-fix into lp://qastaging/unity

lp.1267210-fix
Merge into trunk

Proposed by Brandon Schaefer on 2014-01-08

Status:

Merged

Approved by:

Christopher Townsend on 2014-01-10

Approved revision:

no longer in the source branch.

Merged at revision:

3620

Proposed branch:

lp://qastaging/~brandontschaefer/unity/lp.1267210-fix

Merge into:

lp://qastaging/unity

Diff against target:

226 lines (+112/-1)

9 files modified

launcher/LauncherController.cpp (+4/-1)
plugins/unityshell/src/unityshell.cpp (+5/-0)
tests/autopilot/unity/tests/test_dash.py (+24/-0)
tests/autopilot/unity/tests/test_hud.py (+23/-0)
unity-shared/PluginAdapter.cpp (+43/-0)
unity-shared/PluginAdapter.h (+3/-0)
unity-shared/StandaloneWindowManager.cpp (+6/-0)
unity-shared/StandaloneWindowManager.h (+2/-0)
unity-shared/WindowManager.h (+2/-0)

To merge this branch:

bzr merge lp://qastaging/~brandontschaefer/unity/lp.1267210-fix

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Christopher Townsend (community)		2014-01-08	Approve on 2014-01-10
PS Jenkins bot (community)	continuous-integration		Approve on 2014-01-09
Review via email: mp+200925@code.qastaging.launchpad.net

Commit message

Do not open the dash/hud on a monitor with a top most window that is fullscreen.

Description of the change

When a window is fullscreen, and you try to open the dash/hud it is still opening but not rendering on top. This means focus is being stole from the fullscreen window. This is very confusing.

The fix, do not open the dash/hud if the mouse is on a monitor with a top most window that is fullscreen!

(Hence the amazing function that does all of this! IsTopWindowFullscreenOnMonitorWithMouse()!!)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-01-08:

FAILED: Continuous integration, rev:3617
http://jenkins.qa.ubuntu.com/job/unity-ci/541/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/77/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/73/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/75/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/541/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-01-09:

PASSED: Continuous integration, rev:3618
http://jenkins.qa.ubuntu.com/job/unity-ci/542/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/78
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/74
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/76

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/542/rebuild

review: Approve (continuous-integration)

Revision history for this message

Christopher Townsend (townsend) wrote on 2014-01-09:

I'm seeing an issue related to multi-monitor, but I think it's unrelated to this change, but it should be investigated.

To reproduce the issue:

1. Open gedit on one monitor and make it full screen.
2. Move mouse to the other monitor.
3. Hit Super to bring up the Dash.
4. Hit Super again to close the Dash.

Notice that the panel is now drawn over the full screen Gedit window.

Also, would it make sense to have some additional AP tests for the multi-monitor situations to make sure the Dash/Hud will open on the other monitor, etc?

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-01-09:

PASSED: Continuous integration, rev:3619
http://jenkins.qa.ubuntu.com/job/unity-ci/544/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/80
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/76
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/78