Merge lp://qastaging/~brandontschaefer/unity/no-launcher-delay-when-dash-opens into lp://qastaging/unity
Proposed by
Brandon Schaefer
| Status: | Rejected |
|---|---|
| Rejected by: | Marco Trevisan (Treviño) |
| Proposed branch: | lp://qastaging/~brandontschaefer/unity/no-launcher-delay-when-dash-opens |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
251 lines (+63/-40) 4 files modified
launcher/Launcher.cpp (+26/-20) launcher/Launcher.h (+2/-0) launcher/LauncherController.cpp (+1/-0) manual-tests/Dash.txt (+34/-20) |
| To merge this branch: | bzr merge lp://qastaging/~brandontschaefer/unity/no-launcher-delay-when-dash-opens |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Omer Akram (community) | functional | Approve | |
| Unity Team | Pending | ||
|
Review via email:
|
|||
Commit message
Show the launcher when the dash is opening with out relaying on ubus.
Description of the change
=== Problem ===
When the launcher is set to auto hide. Then the Dash was opened the launcher would delay in showing at times. This is caused by Ubus by async.
=== Fix ===
Show the launcher as the dash is being open with out doing any ubus calls.
=== Tests ===
Manual tests...
*NOTE* before this gets merged it must be tested on a low-spec machine to confirm it will cause the dash futher problems when opening.
To post a comment you must log in.
Revision history for this message
| Michal Hruby (mhr3) wrote | # |
Revision history for this message
| Brandon Schaefer (brandontschaefer) wrote | # |
Unmerged revisions
- 2680. By Brandon Schaefer
-
* The launcher now opens with the dash, instead of relying on UBUS to send the message quick enough.
* Also replaced should with must in the dash manual tests.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Doesn't this make opening dash super slow on low-spec machines? The ubus message has idle priority, so launcher redraws will be prioritized and therefore the dash will actually open much later than it does now? (which is already very bad on slow machines)