Merge lp://qastaging/~bratsche/appmenu-gtk/almost-rewrite into lp://qastaging/appmenu-gtk/0.4

Looks good. Could use a couple comments explaining what happens in fail conditions here and there (like if your proxy is null) but nothing blocking a merge.

+1

Forgive me if I don't know exactly how libappmenu is going to be used - it's not mentioned anywhere in any of the distributed files ;-) From the looks I'd say it was the gtk module that we load into all apps to export the menu on the bus? My comments are based on that at least :-)

I am a bit worried about the NameOwnerChanged signal around line 100... The way you listen for it the process will wake up each time anyone joins or leaves the bus, or any time anyone changes anything with the naming on the bus. So if this is done by all apps linking to gtk it may be a problem.

It's not like these event are very frequent, but they do happen every now and then. The times where we have then en masse is on shutdown and startup. But still just for a regularly running desktop it may have an impact on app startup time - I'm not sure how much though.

Sadly there is no easy fix though. There is a laborious fix :-) That would be manually installing a filter func in libdbus and then adding a MatchRule (with org.freedesktop.DBus.AddMatch) like :

  type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged'arg0='WATCHED_NAME',arg2=''

which matches only when WATCHED_NAME drops off. For an example of playing around with samething like this see http://bazaar.launchpad.net/~unity-team/dee/trunk/annotate/head:/dee/dee-peer.c#L693

Mikkel,

I thought that there was an easy way to get the specific name change in GDBus. I figured we'd pick up that optimization when we ported from dbus-glib to GDBus.

Ted

I'd recommend landing that branch, with the next step being to add the matchrule, as explained by Mikkel. The previous experience with gdbus was not successful, so i'd rather have one bird in the hand asap.

Ted: Yeah name watching is integrated nicely in gdbus as far as I can see

Created a bug to track this https://bugs.launchpad.net/appmenu-gtk/+bug/594805