Merge lp://qastaging/~bratsche/appmenu-gtk/fix-compile-dbus-shared into lp://qastaging/appmenu-gtk/0.4

Proposed by Cody Russell
Status: Merged
Merged at revision: 5
Proposed branch: lp://qastaging/~bratsche/appmenu-gtk/fix-compile-dbus-shared
Merge into: lp://qastaging/appmenu-gtk/0.4
Diff against target: 11 lines (+0/-1)
1 file modified
src/bridge.c (+0/-1)
To merge this branch: bzr merge lp://qastaging/~bratsche/appmenu-gtk/fix-compile-dbus-shared
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+25046@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

  review approve

On Tue, 2010-05-11 at 08:42 +0000, Cody Russell wrote:
> Cody Russell has proposed merging lp:~bratsche/appmenu-gtk/fix-compile-dbus-shared into lp:appmenu-gtk.
>
> Requested reviews:
> Canonical Desktop Experience Team (canonical-dx-team)
> Related bugs:
> #578696 Compile fails from missing dbus-shared.h
> https://bugs.launchpad.net/bugs/578696
>
> differences between files attachment (review-diff.txt)
> === modified file 'src/bridge.c'
> --- src/bridge.c 2010-05-09 19:39:28 +0000
> +++ src/bridge.c 2010-05-11 08:42:24 +0000
> @@ -36,7 +36,6 @@
>
> #include "bridge.h"
> #include "application-menu-registrar-client.h"
> -#include "dbus-shared.h"
>
> #define APP_MENU_DBUS_NAME "org.ayatana.WindowMenu.Registrar"
> #define APP_MENU_DBUS_OBJECT "/org/ayatana/WindowMenu/Registrar"
>

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches