Merge lp://qastaging/~bratsche/appmenu-gtk/rebuild-on-attach into lp://qastaging/appmenu-gtk/0.4
Proposed by
Cody Russell
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 43 | ||||
Proposed branch: | lp://qastaging/~bratsche/appmenu-gtk/rebuild-on-attach | ||||
Merge into: | lp://qastaging/appmenu-gtk/0.4 | ||||
Diff against target: |
16 lines (+6/-0) 1 file modified
src/bridge.c (+6/-0) |
||||
To merge this branch: | bzr merge lp://qastaging/~bratsche/appmenu-gtk/rebuild-on-attach | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Approve | ||
Review via email:
|
Description of the change
This will have no noticeable effect until my gtk+ patch gets merged into Ubuntu. seb128 said he'll do that in the morning.
That gtk+ patch combined with this new revision will fix all remaining issues with missing menuitems and, I believe, with menuitems being out of order.
To post a comment you must log in.
So excited!
review approve
On Mon, 2010-06-28 at 20:45 +0000, Cody Russell wrote: get_toplevel (attach); window_ items (bridge, toplevel);
> Cody Russell has proposed merging lp:~bratsche/appmenu-gtk/rebuild-on-attach into lp:appmenu-gtk.
>
> Requested reviews:
> Canonical Desktop Experience Team (canonical-dx-team)
>
>
> This will have no noticeable effect until my gtk+ patch gets merged into Ubuntu. seb128 said he'll do that in the morning.
>
> That gtk+ patch combined with this new revision will fix all remaining issues with missing menuitems and, I believe, with menuitems being out of order.
> differences between files attachment (review-diff.txt)
> === modified file 'src/bridge.c'
> --- src/bridge.c 2010-06-25 17:45:25 +0000
> +++ src/bridge.c 2010-06-28 20:45:43 +0000
> @@ -771,6 +771,12 @@
> bridge);
> return;
> }
> + else
> + {
> + toplevel = gtk_widget_
> +
> + rebuild_
> + }
> }
>
> if (GTK_IS_WINDOW (toplevel))
>