Open Input Framework

Merge lp://qastaging/~bratsche/oif/eog-rotate-gesture-2 into lp://qastaging/~oif-team/oif/eog-gestures-trunk

  1. eog-rotate-gesture-2
  2. Merge into eog-gestures-trunk
Proposed by Cody Russell
Status: Merged
Merged at revision: 117
Proposed branch: lp://qastaging/~bratsche/oif/eog-rotate-gesture-2
Merge into: lp://qastaging/~oif-team/oif/eog-gestures-trunk
Diff against target: 93 lines (+43/-1)
2 files modified
debian/control (+1/-1)
src/eog-window.c (+42/-0)
To merge this branch: bzr merge lp://qastaging/~bratsche/oif/eog-rotate-gesture-2
Reviewer Review Type Date Requested Status
Henrik Rydberg (community) Needs Fixing
Stephen M. Webb (community) Approve
Review via email: mp+45433@code.qastaging.launchpad.net

Description of the change

Aha, it was trying to merge into the wrong branch. That's what was causing these ridiculous diffs. Sorry. :)

To post a comment you must log in.
Revision history for this message
Stephen M. Webb (bregma) wrote :

I would suggest using a constant instead of hard-coded 1.0 in "rotate->angle >= 1.0" and "rotate->angle <= -1.0" so they can be tweaked a little easier when we figure out better threshold values, and so they can be a little more self-documenting.

Other than that, this change looks clean.

review: Approve
Revision history for this message
Henrik Rydberg (rydberg) wrote :

I agree with Stephens comments, but would rather put that as needs fixing.

review: Needs Fixing
lp://qastaging/~bratsche/oif/eog-rotate-gesture-2 updated
117. By Cody Russell

Add #define for the angles.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches