Merge lp://qastaging/~bratsche/oif/evince-move-gestures-into-view into lp://qastaging/~oif-team/oif/evince-gestures-trunk
Proposed by
Cody Russell
| Status: | Merged |
|---|---|
| Merged at revision: | 4212 |
| Proposed branch: | lp://qastaging/~bratsche/oif/evince-move-gestures-into-view |
| Merge into: | lp://qastaging/~oif-team/oif/evince-gestures-trunk |
| Diff against target: |
580 lines (+237/-164) 6 files modified
configure.ac (+4/-2) libview/ev-view-private.h (+8/-0) libview/ev-view.c (+222/-2) libview/ev-view.h (+1/-1) previewer/ev-previewer-window.c (+1/-1) shell/ev-window.c (+1/-158) |
| To merge this branch: | bzr merge lp://qastaging/~bratsche/oif/evince-move-gestures-into-view |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Stephen M. Webb (community) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2010-12-10.
Description of the change
This branch requires the following first:
https:/
This moves the gesture logic out of EvWindow and into EvView, as well as simply updating evince to work with the libgrip changes in the other merge request.
To post a comment you must log in.
Revision history for this message
| Cody Russell (bratsche) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Please use symbolic constants for threshold values (eg. "drag->velocity_y >= 1.0", "rotate->angle >= 1.0", etc) to (a) make the code more self-documenting and (2) make it easier to find the values to tweak later during the tweak phase.
Other than that, this code looks good. I am unable to build it at the moment to do run-time evaluation.