Open Input Framework

Merge lp://qastaging/~bratsche/oif/evince-smooth-dragging into lp://qastaging/~oif-team/oif/evince-gestures-trunk

  1. evince-smooth-dragging
  2. Merge into evince-gestures-trunk
Proposed by Cody Russell
Status: Merged
Merged at revision: 4210
Proposed branch: lp://qastaging/~bratsche/oif/evince-smooth-dragging
Merge into: lp://qastaging/~oif-team/oif/evince-gestures-trunk
Diff against target: 79 lines (+40/-0)
3 files modified
libview/ev-view.c (+18/-0)
libview/ev-view.h (+5/-0)
shell/ev-window.c (+17/-0)
To merge this branch: bzr merge lp://qastaging/~bratsche/oif/evince-smooth-dragging
Reviewer Review Type Date Requested Status
Mohamed IKBEL Boulabiar (community) Approve
Review via email: mp+42207@code.qastaging.launchpad.net

Description of the change

Currently supports 1-finger panning around the view. 2-fingers are used for flinging to the next/previous page, so 1-finger made sense to me.

To post a comment you must log in.
Revision history for this message
Mohamed IKBEL Boulabiar (boulabiar) wrote :

The patch works pretty nice, but when trying it, it looks like the movement are inverted.

Moving a document/paper by touch seems a better metaphor than moving the camera.
In okular it's like that, so what you think ?

review: Needs Information
Revision history for this message
Cody Russell (bratsche) wrote :

Yeah, you're right. I didn't notice so much using the Magic Trackpad, but if I were using a touchscreen this would feel very wrong. I'll fix it now.

Revision history for this message
Cody Russell (bratsche) wrote :

Fixed in rev 4211.

lp://qastaging/~bratsche/oif/evince-smooth-dragging updated
4211. By Cody Russell

Invert the y axis when dragging.

Revision history for this message
Mohamed IKBEL Boulabiar (boulabiar) wrote :

Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches