Compiz

Merge lp://qastaging/~bregma/compiz/lp-1101594 into lp://qastaging/compiz/0.9.12

  1. lp-1101594
  2. Merge into 0.9.12
Proposed by Stephen M. Webb
Status: Merged
Approved by: Christopher Townsend
Approved revision: 3936
Merged at revision: 3949
Proposed branch: lp://qastaging/~bregma/compiz/lp-1101594
Merge into: lp://qastaging/compiz/0.9.12
Diff against target: 536 lines (+204/-71)
3 files modified
plugins/opengl/include/opengl/texture.h (+127/-33)
plugins/opengl/src/privatetexture.h (+22/-3)
plugins/opengl/src/texture.cpp (+55/-35)
To merge this branch: bzr merge lp://qastaging/~bregma/compiz/lp-1101594
Reviewer Review Type Date Requested Status
Christopher Townsend (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+254656@code.qastaging.launchpad.net

Commit message

OpenGL plugin: refine GLTexture API to adhere to class invariants

Description of the change

OpenGL plugin: refactor GLTexture to pass values in the constructor and maintain class invariants instead of using the C-with-classes default-initialize-and-call-initializer-function that makes Coverity comnplain about uninitialized member variables.

The uninitialized-variables complaint is unlikely to be realized in core Compiz plugins but since it;s a public API that arbitrary third-party plugins could use, it's a poor API. The old API has been deprecated by left in to provide ABI backwards compatibility.

Also, scraped some API docs off compiz.org and added them in to the header while the patient was open on the table.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3935
http://jenkins.qa.ubuntu.com/job/compiz-ci/41/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-vivid-amd64-ci/31
    FAILURE: http://jenkins.qa.ubuntu.com/job/compiz-vivid-armhf-ci/31/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-vivid-i386-ci/31

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/compiz-ci/41/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~bregma/compiz/lp-1101594 updated
3936. By Stephen M. Webb

fixed typo in EGL codepath

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3935
http://jenkins.qa.ubuntu.com/job/compiz-ci/42/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-vivid-amd64-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-vivid-armhf-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-vivid-i386-ci/32

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/compiz-ci/42/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3936
http://jenkins.qa.ubuntu.com/job/compiz-ci/43/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-vivid-amd64-ci/33
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-vivid-armhf-ci/33
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-vivid-i386-ci/33

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/compiz-ci/43/rebuild

review: Approve (continuous-integration)
Revision history for this message
Christopher Townsend (townsend) wrote :

Ok, seems fine.

review: Approve
Revision history for this message
Christopher Townsend (townsend) wrote :

Oh, do we need an ABI bump for this?

Revision history for this message
Christopher Townsend (townsend) wrote :

Ok, all good:)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches