Merge lp://qastaging/~bregma/ginn/build-with-werror into lp://qastaging/ginn

I confirm that the code needs to be refactored.
But Stephen, which things you think they need to be rewritten ?

> I confirm that the code needs to be refactored.
> But Stephen, which things you think they need to be rewritten ?

I think the att and wish structures should be modularized further, the functions for handling them are too distributed across source files.

Some changes are necessary to support device-specific wishes.

I would like to see it rewritten using the GEISv2 API (for efficiency reasons).

Note that, other than the GEISv2 rewrite, most of the changes i would like to see are organizational rather than fundamental. By and large, the program does what it should do in a sensible way, but the way it expressed could be improved.

Any rewrite is not as important as extending an effort to provide more wishes. I think the wish mechanism is solid and does not need a change.

Looks great!

Looks good. The only comment I have is that a __attribute__((unused)) is a GCCism, it should be used through a #define. Something like this:

---- some header ----

#define UNUSED __attribute__((unused))

---------------------

---- Elsewhere -----

gesture_match(GeisGestureType gesture_type,
 GeisGestureId gesture_id UNUSED,
 GeisSize attr_count UNUSED,
 GeisGestureAttr * attrs, int state)

--------------------

There's a point at which abstractions get in the way instead of helping. We don't have any plans even in the really really far future of building any of utouch with a different compiler, so I would prefer to leave gccisms until we decide to change that. OS X uses gcc (and/or llvm which probably uses the same attribute), and I'm sure one can use gcc on windows too.