platform-api

Merge lp://qastaging/~bregma/platform-api/lp-1262671 into lp://qastaging/platform-api

  1. lp-1262671
  2. Merge into trunk
Proposed by Stephen M. Webb
Status: Needs review
Proposed branch: lp://qastaging/~bregma/platform-api/lp-1262671
Merge into: lp://qastaging/platform-api
Diff against target: 1247 lines (+788/-382)
10 files modified
debian/libubuntu-application-api-mirclient1.symbols (+126/-125)
debian/libubuntu-application-api-mirserver1.symbols (+128/-127)
debian/libubuntu-application-api1.symbols (+130/-129)
debian/rules (+1/-1)
src/ubuntu/hybris/CMakeLists.txt (+1/-0)
src/ubuntu/hybris/ubuntu_application_api.ver (+135/-0)
src/ubuntu/mirclient/CMakeLists.txt (+2/-0)
src/ubuntu/mirclient/ubuntu_application_api_mirclient.ver (+131/-0)
src/ubuntu/mirserver/CMakeLists.txt (+1/-0)
src/ubuntu/mirserver/ubuntu_application_api_mirserver.ver (+133/-0)
To merge this branch: bzr merge lp://qastaging/~bregma/platform-api/lp-1262671
Reviewer Review Type Date Requested Status
Gerry Boland (community) Needs Information
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+199662@code.qastaging.launchpad.net

Commit message

added symbol versioning to restrict inintended leakage

Description of the change

Increases the dpkg-gensymbols check level to the highest level by adding the missing 'export' keyword when setting the Makefile variable DPKG_GENSYMBOLS_CHECK_LEVEL so it also get exported to the environment.

WARNING: merging this branch will cause packaging FTBFS because these libraries already export way more symbols than accounted for in the baseline .symbols files. That problem should be resolved first.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:178
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~bregma/platform-api/lp-1262671/+merge/199662/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/platform-api-ci/176/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-trusty-amd64-ci/10/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-trusty-armhf-ci/10/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/platform-api-trusty-i386-ci/10/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/176/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://qastaging/~bregma/platform-api/lp-1262671 updated
179. By Stephen M. Webb

added symbol versioning script to ubuntu_application_api

180. By Stephen M. Webb

added symbol versioning script to ubuntu_application_apii_mirserver

181. By Stephen M. Webb

added symbol versioning script to ubuntu_application_apii_mirclient

182. By Stephen M. Webb

updated .symbols files to add symver entry

183. By Stephen M. Webb

removed Debian revision from some symbols

Revision history for this message
Stephen M. Webb (bregma) wrote :

Should build successfully now _and_ not export a plethora of unwanted symbols.

Bonus: versioned symbols on a key shared library like this can help reduce ABI breakage, should you choose to make that a goal.

Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:183
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~bregma/platform-api/lp-1262671/+merge/199662/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/platform-api-ci/178/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-trusty-amd64-ci/12
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-trusty-armhf-ci/12
        deb: http://jenkins.qa.ubuntu.com/job/platform-api-trusty-armhf-ci/12/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/platform-api-trusty-i386-ci/12

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/platform-api-ci/178/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Gerry Boland (gerboland) wrote :

Sad this dropped for so long, can you update it? Or else kill it please

review: Needs Information
Reply

Unmerged revisions

183. By Stephen M. Webb

removed Debian revision from some symbols

182. By Stephen M. Webb

updated .symbols files to add symver entry

181. By Stephen M. Webb

added symbol versioning script to ubuntu_application_apii_mirclient

180. By Stephen M. Webb

added symbol versioning script to ubuntu_application_apii_mirserver

179. By Stephen M. Webb

added symbol versioning script to ubuntu_application_api

178. By Stephen M. Webb

Makes builds FTBFS on ABI changes (lp: #1262671).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches