Unity Home Scope

Merge lp://qastaging/~bregma/unity-scope-home/lp-1430063 into lp://qastaging/unity-scope-home

  1. lp-1430063
  2. Merge into trunk
Proposed by Stephen M. Webb
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 179
Merged at revision: 180
Proposed branch: lp://qastaging/~bregma/unity-scope-home/lp-1430063
Merge into: lp://qastaging/unity-scope-home
Prerequisite: lp://qastaging/~bregma/unity-scope-home/lp-1430248
Diff against target: 12 lines (+1/-1)
1 file modified
src/smart-scopes-parse.vala (+1/-1)
To merge this branch: bzr merge lp://qastaging/~bregma/unity-scope-home/lp-1430063
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+252435@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-03-09.

Commit message

initialized an uninitialized variable used in an "if" statement

Description of the change

Valac-0.26 (the default on Ubuntu "Vivid Vervet" dev release) is less tolerant of possibly uninitialized variables used as rvalues and flags an error. Initializing the variable eliminates the error.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:179
http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/107/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-vivid-amd64-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-vivid-armhf-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-vivid-i386-ci/1/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-home-ci/107/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

I'm not sure what Jenkins is complaining about, but this change definitely looks good! Thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:179
http://jenkins.qa.ubuntu.com/job/unity-scope-home-ci/109/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-vivid-amd64-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-vivid-armhf-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-home-vivid-i386-ci/3/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-home-ci/109/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: