Unity System Compositor

Merge lp://qastaging/~bregma/unity-system-compositor/add-autopkgtest into lp://qastaging/unity-system-compositor

  1. add-autopkgtest
  2. Merge into trunk
Proposed by Stephen M. Webb
Status: Merged
Approved by: Stephen M. Webb
Approved revision: 263
Merged at revision: 313
Proposed branch: lp://qastaging/~bregma/unity-system-compositor/add-autopkgtest
Merge into: lp://qastaging/unity-system-compositor
Prerequisite: lp://qastaging/~bregma/unity-system-compositor/lp-1677734
Diff against target: 53 lines (+22/-0)
5 files modified
debian/control (+12/-0)
debian/tests/control (+2/-0)
debian/tests/mir (+3/-0)
debian/unity-system-compositor-tests.install (+2/-0)
tests/integration-tests/CMakeLists.txt (+3/-0)
To merge this branch: bzr merge lp://qastaging/~bregma/unity-system-compositor/add-autopkgtest
Reviewer Review Type Date Requested Status
Mir CI Bot continuous-integration Approve
Brandon Schaefer (community) Approve
Cemil Azizoglu Pending
PS Jenkins bot continuous-integration Pending
Kevin DuBois Pending
Alan Griffiths Pending
Chris Halse Rogers Pending
Review via email: mp+321506@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-10-21.

Commit message

added autopkgtest (DEP-8) support and some tests

Description of the change

Added autopkgtest support. Added some tests.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:260
http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ci/295/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-wily-amd64-ci/83
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-wily-armhf-ci/83
        deb: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-wily-armhf-ci/83/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-wily-i386-ci/83

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-system-compositor-ci/295/rebuild

review: Approve (continuous-integration)
Revision history for this message
Chris Halse Rogers (raof) wrote : Posted in a previous version of this proposal

Almost all of this diff is redundant? Could you please drop all the changes removing the trailing commas from the debian/control lists? Having the trailing commas makes diffs more readable, as all the changed lines are significant.

Other than that, LGTM.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:261
http://jenkins.qa.ubuntu.com/job/unity-system-compositor-ci/296/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-wily-amd64-ci/84
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-wily-armhf-ci/84
        deb: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-wily-armhf-ci/84/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-wily-i386-ci/84

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-system-compositor-ci/296/rebuild

review: Approve (continuous-integration)
Revision history for this message
Kevin DuBois (kdub) wrote : Posted in a previous version of this proposal

looks okay to me, although not sure why some of the dependency orderings have changed in control.

review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote : Posted in a previous version of this proposal

There are unrelated changes in debian/control - are they there for a reason?

review: Needs Information
Revision history for this message
Stephen M. Webb (bregma) wrote : Posted in a previous version of this proposal

The unrelated changes in debian/control are due to running wrap-and-sort on it like a good little Debian packager. It gets hard to remember which packages are good citizens and which are contemptuous of best practices, so I just always run it.

If it really causes a problem, I can revert that change.

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote : Posted in a previous version of this proposal

Yay for tests

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-system-compositor-autolanding/123/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-xenial-amd64-autolanding/14/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-xenial-armhf-autolanding/14/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-system-compositor-xenial-i386-autolanding/14/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:261
https://mir-jenkins.ubuntu.com/job/usc-ci/5/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-usc/5/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-0-fetch/128/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/123/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/123/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=xenial/8/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=armhf,release=vivid+overlay/8/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=xenial/8/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/usc-ci/5/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote : Posted in a previous version of this proposal

Text conflict in debian/control
1 conflicts encountered.

review: Needs Fixing
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:262
https://mir-jenkins.ubuntu.com/job/usc-ci/13/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-usc/15/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/312
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/304
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/304
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=xenial/19/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=armhf,release=vivid+overlay/19/console
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=xenial/19/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/usc-ci/13/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:262
https://mir-jenkins.ubuntu.com/job/usc-ci/17/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-usc/20
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/371
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/363
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/363
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=xenial/24
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=xenial/24/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=armhf,release=vivid+overlay/24
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=armhf,release=vivid+overlay/24/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=xenial/24
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=xenial/24/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/usc-ci/17/rebuild

review: Approve (continuous-integration)
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote : Posted in a previous version of this proposal

I'm assuming this is unintentional.
8 + libmirclient-dev (>= 0.13.0),
9 + libmirserver-dev (>= 0.13.0),
10 libglm-dev,
11 - libmirclient-dev (>= 0.19.0),
12 - libmirserver-dev (>= 0.19.0),

review: Needs Fixing
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:263
https://mir-jenkins.ubuntu.com/job/usc-ci/62/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-usc/85
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/4529
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/4519
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/4519
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/4519
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=xenial+overlay/89
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=xenial+overlay/89/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=zesty/89
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=amd64,release=zesty/89/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=armhf,release=vivid+overlay/89
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=armhf,release=vivid+overlay/89/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=xenial+overlay/89
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=xenial+overlay/89/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=zesty/89
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-usc/arch=i386,release=zesty/89/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/usc-ci/62/rebuild

review: Approve (continuous-integration)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Still a good idea imo

review: Approve
Revision history for this message
Mir CI Bot (mir-ci-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches