Merge into trunk : usb_whitelist : Code : Canonical Driver Test Suite

Status:	Merged
Approved by:	Daniel Manrique on 2014-02-26
Approved revision:	2358
Merged at revision:	2359
Proposed branch:	lp://qastaging/~brendan-donegan/cdts/usb_whitelist
Merge into:	lp://qastaging/cdts
Diff against target:	56 lines (+52/-0) 1 file modified plainbox-gui/whitelists/ihv-usb.whitelist (+52/-0)
To merge this branch:	bzr merge lp://qastaging/~brendan-donegan/cdts/usb_whitelist
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Daniel Manrique (community)		Approve on 2014-02-26
Brendan Donegan (community)		Needs Resubmitting on 2014-02-26
Sylvain Pineau (community)		Needs Fixing on 2014-02-25
Chris Gregan	2014-02-25	Pending
Review via email: mp+208120@code.qastaging.launchpad.net

Revision history for this message

Sylvain Pineau (sylvain-pineau) wrote on 2014-02-25:

#

31 +info/hdparm

Won't work unless you also add: info/hdparm_.*.txt

28 +gcov_attachment

I would remove this one, do we really need it, other ihv whitelists don't include this attachment?

19 +lspci_network_attachment

Please remove this one, it will block forever if there's no network, lspci_attachment is enough.

review: Needs Fixing

Revision history for this message

Brendan Donegan (brendan-donegan) wrote on 2014-02-25:

#

Ehh, this is copied from another whitelist. I will by all means fix these, but perhaps we need to give the rest of them an audit as well?

Revision history for this message

Brendan Donegan (brendan-donegan) wrote on 2014-02-26:

#

Ok now?

review: Needs Resubmitting

Revision history for this message

Sylvain Pineau (sylvain-pineau) wrote on 2014-02-26:

#

you can drop dmi_attachment, sysfs_attachment and udev_attachment as they're now pulled in by the submission-resources meta-job

Revision history for this message

Daniel Manrique (roadmr) wrote on 2014-02-26:

#

storage and performance will both essentially run the same script (so it runs twice), which looks a bit strange but that's how it's supposed to work, so I'm OK with this.

review: Approve

Revision history for this message

Daniel Manrique (roadmr) wrote on 2014-02-26:

#

Download full text (3.9 KiB)

The attempt to merge lp:~brendan-donegan/checkbox-ihv-ng/usb_whitelist into lp:checkbox-ihv-ng failed. Below is the output from the failed tests.

[precise] Bringing VM 'up'
[precise] (timing) 7.94user 3.52system 3:55.66elapsed 4%CPU (0avgtext+0avgdata 21612maxresident)k
[precise] (timing) 0inputs+200outputs (0major+194292minor)pagefaults 0swaps
[precise] Starting tests...
[precise] PlainBox GUI build: [32;1mPASS[39;0m
[precise] (timing) 0.82user 0.31system 1:01.92elapsed 1%CPU (0avgtext+0avgdata 20520maxresident)k
[precise] (timing) 0inputs+56outputs (0major+61827minor)pagefaults 0swaps
[precise] CheckBox test suite: [32;1mPASS[39;0m
[precise] (timing) 0.86user 0.38system 0:36.30elapsed 3%CPU (0avgtext+0avgdata 20144maxresident)k
[precise] (timing) 0inputs+40outputs (0major+61559minor)pagefaults 0swaps
[precise] (timing) 0.83user 0.31system 0:05.79elapsed 19%CPU (0avgtext+0avgdata 19932maxresident)k
[precise] (timing) 0inputs+16outputs (0major+61650minor)pagefaults 0swaps
[precise] PlainBox test suite: [32;1mPASS[39;0m
[precise] (timing) 1.12user 0.32system 0:17.31elapsed 8%CPU (0avgtext+0avgdata 20348maxresident)k
[precise] (timing) 0inputs+232outputs (0major+61184minor)pagefaults 0swaps
[precise] PlainBox documentation build: [32;1mPASS[39;0m
[precise] (timing) 0.91user 0.34system 0:19.99elapsed 6%CPU (0avgtext+0avgdata 20680maxresident)k
[precise] (timing) 0inputs+16outputs (0major+61337minor)pagefaults 0swaps
[precise] CheckBoxNG test suite: [32;1mPASS[39;0m
[precise] (timing) 0.78user 0.35system 0:06.57elapsed 17%CPU (0avgtext+0avgdata 20072maxresident)k
[precise] (timing) 0inputs+16outputs (0major+61754minor)pagefaults 0swaps
[precise] Integration tests: [32;1mPASS[39;0m
[precise] (timing) 0.80user 0.33system 0:07.39elapsed 15%CPU (0avgtext+0avgdata 20016maxresident)k
[precise] (timing) 0inputs+8outputs (0major+61687minor)pagefaults 0swaps
[precise] Destroying VM
[trusty] Bringing VM 'up'
[trusty] (timing) 10.48user 4.50system 5:35.46elapsed 4%CPU (0avgtext+0avgdata 21320maxresident)k
[trusty] (timing) 0inputs+248outputs (0major+283975minor)pagefaults 0swaps
[trusty] Starting tests...
[trusty] PlainBox GUI build: [32;1mPASS[39;0m
[trusty] (timing) 1.27user 0.46system 1:15.81elapsed 2%CPU (0avgtext+0avgdata 20152maxresident)k
[trusty] (timing) 7248inputs+80outputs (84major+60987minor)pagefaults 0swaps
[trusty] CheckBox test suite: [32;1mPASS[39;0m
[trusty] (timing) 0.81user 0.34system 0:41.07elapsed 2%CPU (0avgtext+0avgdata 20248maxresident)k
[trusty] (timing) 0inputs+40outputs (0major+60354minor)pagefaults 0swaps
[trusty] (timing) 0.80user 0.31system 0:07.05elapsed 15%CPU (0avgtext+0avgdata 20016maxresident)k
[trusty] (timing) 0inputs+16outputs (0major+59864minor)pagefaults 0swaps
[trusty] PlainBox test suite: [31;1mFAIL[39;0m
[trusty] stdout: http://paste.ubuntu.com/7000949/
[trusty] stderr: http://paste.ubuntu.com/7000950/
[trusty] (timing) Command exited with non-zero status 1
[trusty] (timing) 0.89user 0.34system 0:15.75elapsed 7%CPU (0avgtext+0avgdata 20468maxresident)k
[trusty] (timing) 0inputs+160outputs (0major+59789minor)pagefaults 0swaps
[trusty] PlainBox documentation build: [32;1mPASS[39;0m
[trusty] (tim...

The attempt to merge lp:~brendan-donegan/checkbox-ihv-ng/usb_whitelist into lp:checkbox-ihv-ng failed. Below is the output from the failed tests.

[precise] Bringing VM 'up'
[precise] (timing) 7.94user 3.52system 3:55.66elapsed 4%CPU (0avgtext+0avgdata 21612maxresident)k
[precise] (timing) 0inputs+200outputs (0major+194292minor)pagefaults 0swaps
[precise] Starting tests...
[precise] PlainBox GUI build: [32;1mPASS[39;0m
[precise] (timing) 0.82user 0.31system 1:01.92elapsed 1%CPU (0avgtext+0avgdata 20520maxresident)k
[precise] (timing) 0inputs+56outputs (0major+61827minor)pagefaults 0swaps
[precise] CheckBox test suite: [32;1mPASS[39;0m
[precise] (timing) 0.86user 0.38system 0:36.30elapsed 3%CPU (0avgtext+0avgdata 20144maxresident)k
[precise] (timing) 0inputs+40outputs (0major+61559minor)pagefaults 0swaps
[precise] (timing) 0.83user 0.31system 0:05.79elapsed 19%CPU (0avgtext+0avgdata 19932maxresident)k
[precise] (timing) 0inputs+16outputs (0major+61650minor)pagefaults 0swaps
[precise] PlainBox test suite: [32;1mPASS[39;0m
[precise] (timing) 1.12user 0.32system 0:17.31elapsed 8%CPU (0avgtext+0avgdata 20348maxresident)k
[precise] (timing) 0inputs+232outputs (0major+61184minor)pagefaults 0swaps
[precise] PlainBox documentation build: [32;1mPASS[39;0m
[precise] (timing) 0.91user 0.34system 0:19.99elapsed 6%CPU (0avgtext+0avgdata 20680maxresident)k
[precise] (timing) 0inputs+16outputs (0major+61337minor)pagefaults 0swaps
[precise] CheckBoxNG test suite: [32;1mPASS[39;0m
[precise] (timing) 0.78user 0.35system 0:06.57elapsed 17%CPU (0avgtext+0avgdata 20072maxresident)k
[precise] (timing) 0inputs+16outputs (0major+61754minor)pagefaults 0swaps
[precise] Integration tests: [32;1mPASS[39;0m
[precise] (timing) 0.80user 0.33system 0:07.39elapsed 15%CPU (0avgtext+0avgdata 20016maxresident)k
[precise] (timing) 0inputs+8outputs (0major+61687minor)pagefaults 0swaps
[precise] Destroying VM
[trusty] Bringing VM 'up'
[trusty] (timing) 10.48user 4.50system 5:35.46elapsed 4%CPU (0avgtext+0avgdata 21320maxresident)k
[trusty] (timing) 0inputs+248outputs (0major+283975minor)pagefaults 0swaps
[trusty] Starting tests...
[trusty] PlainBox GUI build: [32;1mPASS[39;0m
[trusty] (timing) 1.27user 0.46system 1:15.81elapsed 2%CPU (0avgtext+0avgdata 20152maxresident)k
[trusty] (timing) 7248inputs+80outputs (84major+60987minor)pagefaults 0swaps
[trusty] CheckBox test suite: [32;1mPASS[39;0m
[trusty] (timing) 0.81user 0.34system 0:41.07elapsed 2%CPU (0avgtext+0avgdata 20248maxresident)k
[trusty] (timing) 0inputs+40outputs (0major+60354minor)pagefaults 0swaps
[trusty] (timing) 0.80user 0.31system 0:07.05elapsed 15%CPU (0avgtext+0avgdata 20016maxresident)k
[trusty] (timing) 0inputs+16outputs (0major+59864minor)pagefaults 0swaps
[trusty] PlainBox test suite: [31;1mFAIL[39;0m
[trusty] stdout: http://paste.ubuntu.com/7000949/
[trusty] stderr: http://paste.ubuntu.com/7000950/
[trusty] (timing) Command exited with non-zero status 1
[trusty] (timing) 0.89user 0.34system 0:15.75elapsed 7%CPU (0avgtext+0avgdata 20468maxresident)k
[trusty] (timing) 0inputs+160outputs (0major+59789minor)pagefaults 0swaps
[trusty] PlainBox documentation build: [32;1mPASS[39;0m
[trusty] (timing) 0.79user 0.32system 0:19.61elapsed 5%CPU (0avgtext+0avgdata 20044maxresident)k
[trusty] (timing) 0inputs+16outputs (0major+59816minor)pagefaults 0swaps
[trusty] CheckBoxNG test suite: [32;1mPASS[39;0m
[trusty] (timing) 0.81user 0.31system 0:06.92elapsed 16%CPU (0avgtext+0avgdata 20096maxresident)k
[trusty] (timing) 0inputs+16outputs (0major+59713minor)pagefaults 0swaps
[trusty] Integration tests: [31;1mFAIL[39;0m
[trusty] stdout: 
[trusty] stderr: http://paste.ubuntu.com/7000951/
[trusty] (timing) Command exited with non-zero status 1
[trusty] (timing) 0.84user 0.28system 0:07.84elapsed 14%CPU (0avgtext+0avgdata 20016maxresident)k
[trusty] (timing) 0inputs+8outputs (0major+60423minor)pagefaults 0swaps
[trusty] Destroying VM

You are trying to send an empty document, exiting.

Revision history for this message

Zygmunt Krynicki (zyga) wrote on 2014-02-26:

#

Download full text (4.3 KiB)

This is very odd. We fixed that. Python 3.4 perhaps?
26 lut 2014 18:42 "Daniel Manrique" <email address hidden>
napisał(a):

> The attempt to merge lp:~brendan-donegan/checkbox-ihv-ng/usb_whitelist
> into lp:checkbox-ihv-ng failed. Below is the output from the failed tests.
>
> [precise] Bringing VM 'up'
> [precise] (timing) 7.94user 3.52system 3:55.66elapsed 4%CPU
> (0avgtext+0avgdata 21612maxresident)k
> [precise] (timing) 0inputs+200outputs (0major+194292minor)pagefaults 0swaps
> [precise] Starting tests...
> [precise] PlainBox GUI build: [32;1mPASS [39;0m
> [precise] (timing) 0.82user 0.31system 1:01.92elapsed 1%CPU
> (0avgtext+0avgdata 20520maxresident)k
> [precise] (timing) 0inputs+56outputs (0major+61827minor)pagefaults 0swaps
> [precise] CheckBox test suite: [32;1mPASS [39;0m
> [precise] (timing) 0.86user 0.38system 0:36.30elapsed 3%CPU
> (0avgtext+0avgdata 20144maxresident)k
> [precise] (timing) 0inputs+40outputs (0major+61559minor)pagefaults 0swaps
> [precise] (timing) 0.83user 0.31system 0:05.79elapsed 19%CPU
> (0avgtext+0avgdata 19932maxresident)k
> [precise] (timing) 0inputs+16outputs (0major+61650minor)pagefaults 0swaps
> [precise] PlainBox test suite: [32;1mPASS [39;0m
> [precise] (timing) 1.12user 0.32system 0:17.31elapsed 8%CPU
> (0avgtext+0avgdata 20348maxresident)k
> [precise] (timing) 0inputs+232outputs (0major+61184minor)pagefaults 0swaps
> [precise] PlainBox documentation build: [32;1mPASS [39;0m
> [precise] (timing) 0.91user 0.34system 0:19.99elapsed 6%CPU
> (0avgtext+0avgdata 20680maxresident)k
> [precise] (timing) 0inputs+16outputs (0major+61337minor)pagefaults 0swaps
> [precise] CheckBoxNG test suite: [32;1mPASS [39;0m
> [precise] (timing) 0.78user 0.35system 0:06.57elapsed 17%CPU
> (0avgtext+0avgdata 20072maxresident)k
> [precise] (timing) 0inputs+16outputs (0major+61754minor)pagefaults 0swaps
> [precise] Integration tests: [32;1mPASS [39;0m
> [precise] (timing) 0.80user 0.33system 0:07.39elapsed 15%CPU
> (0avgtext+0avgdata 20016maxresident)k
> [precise] (timing) 0inputs+8outputs (0major+61687minor)pagefaults 0swaps
> [precise] Destroying VM
> [trusty] Bringing VM 'up'
> [trusty] (timing) 10.48user 4.50system 5:35.46elapsed 4%CPU
> (0avgtext+0avgdata 21320maxresident)k
> [trusty] (timing) 0inputs+248outputs (0major+283975minor)pagefaults 0swaps
> [trusty] Starting tests...
> [trusty] PlainBox GUI build: [32;1mPASS [39;0m
> [trusty] (timing) 1.27user 0.46system 1:15.81elapsed 2%CPU
> (0avgtext+0avgdata 20152maxresident)k
> [trusty] (timing) 7248inputs+80outputs (84major+60987minor)pagefaults
> 0swaps
> [trusty] CheckBox test suite: [32;1mPASS [39;0m
> [trusty] (timing) 0.81user 0.34system 0:41.07elapsed 2%CPU
> (0avgtext+0avgdata 20248maxresident)k
> [trusty] (timing) 0inputs+40outputs (0major+60354minor)pagefaults 0swaps
> [trusty] (timing) 0.80user 0.31system 0:07.05elapsed 15%CPU
> (0avgtext+0avgdata 20016maxresident)k
> [trusty] (timing) 0inputs+16outputs (0major+59864minor)pagefaults 0swaps
> [trusty] PlainBox test suite: [31;1mFAIL [39;0m
> [trusty] stdout: http://paste.ubuntu.com/7000949/
> [trusty] stderr: http://paste.ubuntu.com/7000950/
> [trusty] (timing) Command exited with non-zero stat...

This is very odd. We fixed that. Python 3.4 perhaps?
26 lut 2014 18:42 "Daniel Manrique" <daniel.manrique@canonical.com>
napisał(a):

> The attempt to merge lp:~brendan-donegan/checkbox-ihv-ng/usb_whitelist
> into lp:checkbox-ihv-ng failed. Below is the output from the failed tests.
>
> [precise] Bringing VM 'up'
> [precise] (timing) 7.94user 3.52system 3:55.66elapsed 4%CPU
> (0avgtext+0avgdata 21612maxresident)k
> [precise] (timing) 0inputs+200outputs (0major+194292minor)pagefaults 0swaps
> [precise] Starting tests...
> [precise] PlainBox GUI build:  [32;1mPASS [39;0m
> [precise] (timing) 0.82user 0.31system 1:01.92elapsed 1%CPU
> (0avgtext+0avgdata 20520maxresident)k
> [precise] (timing) 0inputs+56outputs (0major+61827minor)pagefaults 0swaps
> [precise] CheckBox test suite:  [32;1mPASS [39;0m
> [precise] (timing) 0.86user 0.38system 0:36.30elapsed 3%CPU
> (0avgtext+0avgdata 20144maxresident)k
> [precise] (timing) 0inputs+40outputs (0major+61559minor)pagefaults 0swaps
> [precise] (timing) 0.83user 0.31system 0:05.79elapsed 19%CPU
> (0avgtext+0avgdata 19932maxresident)k
> [precise] (timing) 0inputs+16outputs (0major+61650minor)pagefaults 0swaps
> [precise] PlainBox test suite:  [32;1mPASS [39;0m
> [precise] (timing) 1.12user 0.32system 0:17.31elapsed 8%CPU
> (0avgtext+0avgdata 20348maxresident)k
> [precise] (timing) 0inputs+232outputs (0major+61184minor)pagefaults 0swaps
> [precise] PlainBox documentation build:  [32;1mPASS [39;0m
> [precise] (timing) 0.91user 0.34system 0:19.99elapsed 6%CPU
> (0avgtext+0avgdata 20680maxresident)k
> [precise] (timing) 0inputs+16outputs (0major+61337minor)pagefaults 0swaps
> [precise] CheckBoxNG test suite:  [32;1mPASS [39;0m
> [precise] (timing) 0.78user 0.35system 0:06.57elapsed 17%CPU
> (0avgtext+0avgdata 20072maxresident)k
> [precise] (timing) 0inputs+16outputs (0major+61754minor)pagefaults 0swaps
> [precise] Integration tests:  [32;1mPASS [39;0m
> [precise] (timing) 0.80user 0.33system 0:07.39elapsed 15%CPU
> (0avgtext+0avgdata 20016maxresident)k
> [precise] (timing) 0inputs+8outputs (0major+61687minor)pagefaults 0swaps
> [precise] Destroying VM
> [trusty] Bringing VM 'up'
> [trusty] (timing) 10.48user 4.50system 5:35.46elapsed 4%CPU
> (0avgtext+0avgdata 21320maxresident)k
> [trusty] (timing) 0inputs+248outputs (0major+283975minor)pagefaults 0swaps
> [trusty] Starting tests...
> [trusty] PlainBox GUI build:  [32;1mPASS [39;0m
> [trusty] (timing) 1.27user 0.46system 1:15.81elapsed 2%CPU
> (0avgtext+0avgdata 20152maxresident)k
> [trusty] (timing) 7248inputs+80outputs (84major+60987minor)pagefaults
> 0swaps
> [trusty] CheckBox test suite:  [32;1mPASS [39;0m
> [trusty] (timing) 0.81user 0.34system 0:41.07elapsed 2%CPU
> (0avgtext+0avgdata 20248maxresident)k
> [trusty] (timing) 0inputs+40outputs (0major+60354minor)pagefaults 0swaps
> [trusty] (timing) 0.80user 0.31system 0:07.05elapsed 15%CPU
> (0avgtext+0avgdata 20016maxresident)k
> [trusty] (timing) 0inputs+16outputs (0major+59864minor)pagefaults 0swaps
> [trusty] PlainBox test suite:  [31;1mFAIL [39;0m
> [trusty] stdout: http://paste.ubuntu.com/7000949/
> [trusty] stderr: http://paste.ubuntu.com/7000950/
> [trusty] (timing) Command exited with non-zero status 1
> [trusty] (timing) 0.89user 0.34system 0:15.75elapsed 7%CPU
> (0avgtext+0avgdata 20468maxresident)k
> [trusty] (timing) 0inputs+160outputs (0major+59789minor)pagefaults 0swaps
> [trusty] PlainBox documentation build:  [32;1mPASS [39;0m
> [trusty] (timing) 0.79user 0.32system 0:19.61elapsed 5%CPU
> (0avgtext+0avgdata 20044maxresident)k
> [trusty] (timing) 0inputs+16outputs (0major+59816minor)pagefaults 0swaps
> [trusty] CheckBoxNG test suite:  [32;1mPASS [39;0m
> [trusty] (timing) 0.81user 0.31system 0:06.92elapsed 16%CPU
> (0avgtext+0avgdata 20096maxresident)k
> [trusty] (timing) 0inputs+16outputs (0major+59713minor)pagefaults 0swaps
> [trusty] Integration tests:  [31;1mFAIL [39;0m
> [trusty] stdout:
> [trusty] stderr: http://paste.ubuntu.com/7000951/
> [trusty] (timing) Command exited with non-zero status 1
> [trusty] (timing) 0.84user 0.28system 0:07.84elapsed 14%CPU
> (0avgtext+0avgdata 20016maxresident)k
> [trusty] (timing) 0inputs+8outputs (0major+60423minor)pagefaults 0swaps
> [trusty] Destroying VM
>
> You are trying to send an empty document, exiting.
>
> --
>
> https://code.launchpad.net/~brendan-donegan/checkbox-ihv-ng/usb_whitelist/+merge/208120
> You are subscribed to branch lp:checkbox-ihv-ng.
>

Revision history for this message

Daniel Manrique (roadmr) wrote on 2014-02-26:

#

I dropped the failing (and irrelevant) tests from checkbox-ihv-ng, reapproving so it goes in the tarmac queue after the testing fix.

review: Approve

Canonical Driver Test Suite

Merge lp://qastaging/~brendan-donegan/cdts/usb_whitelist into lp://qastaging/cdts

Commit message

Description of the change

Preview Diff

Subscribers