Merge lp://qastaging/~brendan-donegan/checkbox/bug1019162_wireless_soft_unblock into lp://qastaging/checkbox

Unless you intend to do anything with the output of rfkill, I would avoid assigning it to a variable. If someone looks at the code, they might see that the variable is no longer used, so they might think that both the variable and the call are unnecessary. By removing the variable, this removes that potential risk.

Good point, thanks

Removed the assignment of the check_call result

Thanks for the changes! I noticed a couple more things that we might want to consider:

1. Do you think we should take this opportunity to improve the output so that it's printed to stderr when exiting with non-zero:

print("Failed to activate %s." % connection, file=sys.stderr)
sys.exit(1)

2. Do you think that if the rfkill call fails, that the script should return non-zero:

    try:
        check_call(['rfkill','unblock','wlan','wifi'])
    except CalledProcessError:
        print("Could not unblock wireless devices with rfkill.", file=sys.stderr)
        sys.exit(1)

These are not regressions from before though, so I'm easy with your decision either way. Please let me know what you think.

2. I'm reluctant to, without understanding how and when rfkill fails. If the unblock doesn't work it's going to exhibit as a test failure anyway.

Made errors output to stderr

Thanks for making these changes!