Checkbox

Merge lp://qastaging/~brendan-donegan/checkbox/bug1149288 into lp://qastaging/checkbox

  1. bug1149288
  2. Merge into trunk
Proposed by Brendan Donegan
Status: Merged
Approved by: Daniel Manrique
Approved revision: 1965
Merged at revision: 1965
Proposed branch: lp://qastaging/~brendan-donegan/checkbox/bug1149288
Merge into: lp://qastaging/checkbox
Diff against target: 33 lines (+5/-1)
3 files modified
data/whitelists/sniff.whitelist (+2/-0)
debian/changelog (+2/-0)
jobs/miscellanea.txt.in (+1/-1)
To merge this branch: bzr merge lp://qastaging/~brendan-donegan/checkbox/bug1149288
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+151953@code.qastaging.launchpad.net

Description of the change

As noticed by CE QA, the sources-list test was broken by the changes to the sources_test script. This branch updates the test to get the parameters passed to the script as it expects.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Looks OK, thanks!

One question, how are users supposed to define the parameters? using environment variables? just curious.

review: Approve
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

They're supposed to define them in the job command, so that you can have different tests for different sources lists

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches