Checkbox

Merge lp://qastaging/~brendan-donegan/checkbox/bug1314516_plainbox into lp://qastaging/checkbox

  1. bug1314516_plainbox
  2. Merge into trunk
Proposed by Brendan Donegan
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 2982
Merged at revision: 2984
Proposed branch: lp://qastaging/~brendan-donegan/checkbox/bug1314516_plainbox
Merge into: lp://qastaging/checkbox
Diff against target: 12 lines (+1/-1)
1 file modified
plainbox/plainbox/impl/commands/run.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~brendan-donegan/checkbox/bug1314516_plainbox
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Brendan Donegan (community) Needs Resubmitting
Review via email: mp+218809@code.qastaging.launchpad.net

Description of the change

Really simple - use summary instead of id for displaying jobs during the run command.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Perhaps tr_summary() ?

review: Needs Fixing
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Why the question mark? Do you think I need to fix the other 'fixes' i did for GUI and CLI? I completely forgot about tr summary

lp://qastaging/~brendan-donegan/checkbox/bug1314516_plainbox updated
2982. By Brendan Donegan

plainbox: Show summary instead of id for jobs during run command

Signed-off-by: Brendan Donegan <email address hidden>

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

updated to use tr_summary(). still wondering about the other merges

review: Needs Resubmitting
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

The question mark was just to subtly imply that I wanted that change. Thanks :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches