Merge lp://qastaging/~brendan-donegan/checkbox/bug671144_xorg_version into lp://qastaging/checkbox

Proposed by Brendan Donegan
Status: Merged
Approved by: Daniel Manrique
Approved revision: 1130
Merged at revision: 1132
Proposed branch: lp://qastaging/~brendan-donegan/checkbox/bug671144_xorg_version
Merge into: lp://qastaging/checkbox
Diff against target: 51 lines (+5/-10)
2 files modified
debian/changelog (+2/-0)
jobs/graphics.txt.in (+3/-10)
To merge this branch: bzr merge lp://qastaging/~brendan-donegan/checkbox/bug671144_xorg_version
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Sylvain Pineau (community) Approve
Review via email: mp+83290@code.qastaging.launchpad.net

Description of the change

This branch removes the 'graphics/xorg-version-output' job from 'graphics.txt.in'. Normally we don't remove tests, just de-whitelist them, but this test is now redundant with 'graphics/xorg-version' doing the exact same thing. I'd therefore say we should remove it to avoid confusion.

Note that this test is not used in the default whitelist and I have issued an update to the certification whitelists to replace it with xorg-version.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

It's pretty straightforward. As agreed some time ago, I requested review from Sylvain, so he can be aware of the change and let us know if it affects their tests in any way.

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

We did a similar clean-up in our graphic tests. And it's time to use your test for this purpose now.
Thanks and approved.

review: Approve
Revision history for this message
Daniel Manrique (roadmr) wrote :

Approved, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches