Merge lp://qastaging/~brendan-donegan/checkbox/plainbox_gui_transplant_packaging into lp://qastaging/~checkbox-dev/checkbox/checkbox-packaging
Proposed by
Brendan Donegan
| Status: | Rejected |
|---|---|
| Rejected by: | Zygmunt Krynicki |
| Proposed branch: | lp://qastaging/~brendan-donegan/checkbox/plainbox_gui_transplant_packaging |
| Merge into: | lp://qastaging/~checkbox-dev/checkbox/checkbox-packaging |
| Diff against target: |
298 lines (+78/-29) 9 files modified
debian/canonical-certification-server.install (+2/-2) debian/checkbox-gui.install (+4/-0) debian/checkbox-ng-service.install (+1/-1) debian/checkbox.install (+1/-1) debian/control (+63/-20) debian/python3-checkbox-ng.install (+1/-1) debian/python3-checkbox.install (+1/-1) debian/python3-plainbox.install (+2/-2) debian/rules (+3/-1) |
| To merge this branch: | bzr merge lp://qastaging/~brendan-donegan/checkbox/plainbox_gui_transplant_packaging |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zygmunt Krynicki (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
This merge includes changes to the checkbox packaging branch to include the new checkbox-gui package.
To post a comment you must log in.
Revision history for this message
| Daniel Manrique (roadmr) wrote | # |
Revision history for this message
| Zygmunt Krynicki (zyga) wrote | # |
Unmerged revisions
- 69. By Brendan Donegan
-
Another run of wrap and sort
- 68. By Brendan Donegan
-
Add desktop file to install of checkbox-gui
- 67. By Brendan Donegan
-
wrap and sort run
- 66. By Brendan Donegan
-
checkbox-gui depend on checkbox-ng-service
- 65. By Brendan Donegan
-
Exclude the whole checkbox-gui package
- 64. By Brendan Donegan
-
Mention the binary by name (brute force)
- 63. By Brendan Donegan
-
Try the binary package name instead of a path
- 62. By Brendan Donegan
-
Try excluding checkbox-gui from dh_python3
- 61. By Brendan Donegan
-
Qt package doesn't need python3 depends
- 60. By Brendan Donegan
-
Any not All
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I see you didn't run wrap-and-sort. It may be worth doing so, since you're fixing and tidying up packaging anyway.
Run this in the top-level directory for packaging (i.e. if you do "ls" you should see the "debian" subdirectory). Then just look at the diff to ensure it didn't do anything unexpected.