Merge lp://qastaging/~brendan-donegan/hwcert-tools/certificate_check into lp://qastaging/~hardware-certification/hwcert-tools/reporting-tools
Proposed by
Brendan Donegan
Status: | Merged |
---|---|
Approved by: | Daniel Manrique |
Approved revision: | 125 |
Merged at revision: | 123 |
Proposed branch: | lp://qastaging/~brendan-donegan/hwcert-tools/certificate_check |
Merge into: | lp://qastaging/~hardware-certification/hwcert-tools/reporting-tools |
Diff against target: |
93 lines (+89/-0) 1 file modified
certification_reports/certificate_check.py (+89/-0) |
To merge this branch: | bzr merge lp://qastaging/~brendan-donegan/hwcert-tools/certificate_check |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Manrique (community) | Approve | ||
Brendan Donegan (community) | Needs Resubmitting | ||
Review via email:
|
Description of the change
This is a new script which is going to implement some sanity checks of certified hardware to catch common errors made by certifiers. The first check implemented is to identify hardware which has a public certificate but is marked confidential. This can be a valid state, but often is not, so highlighting such instances can help to catch mistakes.
To post a comment you must log in.
Great idea, thanks for going forward with implementing this!
The script takes ages to run with no indication of progress (it's still running as I send this). This is fine for the intended use case of running from a cron script, but I'd still like to see a -v switch (or default verbosity with a -q switch to quiet things for cron runs), otherwise I have no idea what's happening when trying to test it.
Also, I could suggest you have a look at checkbox- message- get-c4, I implemented a caching mechanism so that the reporting parts of the script can be run with pre-fetched data, which speeds up development considerably (i.e. not waiting 15 minutes to test if some modifications or new reporting in the script work as intended). This would also allow, for instance, a single ""fetch" action and then one or several scripts that take that data and report on it in interesting ways.
It's only a suggestion though, so I'll set as Needs Information to see what you think about this.