Merge lp://qastaging/~brendan-donegan/hwcert-tools/certification_blockers_update_importance into lp://qastaging/~hardware-certification/hwcert-tools/reporting-tools

Proposed by Brendan Donegan
Status: Merged
Approved by: Daniel Manrique
Approved revision: no longer in the source branch.
Merged at revision: 101
Proposed branch: lp://qastaging/~brendan-donegan/hwcert-tools/certification_blockers_update_importance
Merge into: lp://qastaging/~hardware-certification/hwcert-tools/reporting-tools
Diff against target: 154 lines (+56/-17)
2 files modified
certification_reports/certification_blockers.py (+55/-16)
certification_reports/data/blockers_bugs.html (+1/-1)
To merge this branch: bzr merge lp://qastaging/~brendan-donegan/hwcert-tools/certification_blockers_update_importance
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Brendan Donegan (community) Needs Resubmitting
hardware-certification-devel Pending
Review via email: mp+165368@code.qastaging.launchpad.net

Description of the change

Enable 'certification_blockers bugs' command to update the Importance of both blocking and non-blocking bugs according to a specified formula. Some refactoring of the code was necessary due to the unexpected requirement to include non-blocking bugs - since non-blocking bugs can exist on systems that have passed certification, we suddenly needed to include not just failed systems but passed ones too in our calculations.

Note that the report itself will not show anything different.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Oops, stray import pdb on line 137 of the diff?

Other than this, it looks OK.

review: Needs Fixing
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Gah, hate when that happens

review: Needs Resubmitting
Revision history for this message
Daniel Manrique (roadmr) wrote :

+1, thanks!

review: Approve
101. By Daniel Manrique

Enable 'certification_blockers bugs' command to update the Importance of both blocking and non-blocking bugs according to a specified formula - by brendand

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches