Hardware Certification Tools

Merge lp://qastaging/~brendan-donegan/hwcert-tools/datacenter_batching into lp://qastaging/~hardware-certification/hwcert-tools/reporting-tools

  1. datacenter_batching
  2. Merge into reporting-tools
Proposed by Brendan Donegan
Status: Merged
Approved by: Daniel Manrique
Approved revision: 122
Merged at revision: 122
Proposed branch: lp://qastaging/~brendan-donegan/hwcert-tools/datacenter_batching
Merge into: lp://qastaging/~hardware-certification/hwcert-tools/reporting-tools
Diff against target: 31 lines (+11/-10)
1 file modified
certification_reports/certification_report.py (+11/-10)
To merge this branch: bzr merge lp://qastaging/~brendan-donegan/hwcert-tools/datacenter_batching
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+192867@code.qastaging.launchpad.net

Description of the change

Originally we were retrieving all of the datacenter info in one batch, which worked okay for a while - however with an ever growing dataset we ran into problems processing it and started getting 502 errors from c3. This merge request basically fetches a datacenter at a time to try and avoid this issue.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Are datacentres guaranteed to not have holes? i.e. what happens if datacentre 3 gets deleted? If I'm reading this correctly, in that case it would only fetch 1-2, and forget about 4 and above.

This is unlikely to happen so I'll approve anyway, if you think this will be an issue we can fix it later.

review: Approve
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Lol - no! If it happens then we're f**ked. However there's not really anything else we can do here (I don't think) and it is unlikely to happen.

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Looks like we need to set this branch up on tarmac. I'm going to merge it manually in the meantime.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches