Merge lp://qastaging/~brendan-donegan/hwcert-tools/sru_report_diff_fix into lp://qastaging/~hardware-certification/hwcert-tools/reporting-tools

Proposed by Brendan Donegan
Status: Merged
Approved by: Daniel Manrique
Approved revision: 141
Merged at revision: 141
Proposed branch: lp://qastaging/~brendan-donegan/hwcert-tools/sru_report_diff_fix
Merge into: lp://qastaging/~hardware-certification/hwcert-tools/reporting-tools
Diff against target: 19 lines (+5/-4)
1 file modified
certification_reports/certification_report.py (+5/-4)
To merge this branch: bzr merge lp://qastaging/~brendan-donegan/hwcert-tools/sru_report_diff_fix
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+209099@code.qastaging.launchpad.net

Description of the change

The updated certification report script was getting the result for the previous kernel even if none was specified - this led to spurious warnings which were harmless, but annoying. It makes no sense to do this, so let's avoid doing so if no diff-package has been specified.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Makes sense, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches