Merge lp://qastaging/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_minor_fixes into lp://qastaging/ubuntu-autopilot-tests/ubuntu-experience-tests

Proposed by Brendan Donegan
Status: Merged
Approved by: Leo Arias
Approved revision: 23
Merged at revision: 23
Proposed branch: lp://qastaging/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_minor_fixes
Merge into: lp://qastaging/ubuntu-autopilot-tests/ubuntu-experience-tests
Diff against target: 27 lines (+3/-1)
1 file modified
ubuntu_experience_tests/helpers.py (+3/-1)
To merge this branch: bzr merge lp://qastaging/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_minor_fixes
Reviewer Review Type Date Requested Status
Leo Arias (community) Approve
Chris Gagnon (community) Approve
Review via email: mp+223735@code.qastaging.launchpad.net

Description of the change

Fix a couple of minor issues that slipped in with the ContactsDbusService branch.

To post a comment you must log in.
Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

lgtm

review: Approve
Revision history for this message
Leo Arias (elopio) wrote :

It still doesn't pass flake8:
$ flake8 ../ubuntu_experience_tests/helpers.py:99:1: E302 expected 2 blank lines, found 1

review: Needs Fixing
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

There we go

Revision history for this message
Leo Arias (elopio) wrote :

Thank you!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches