Ubuntu Autopilot Tests

Merge lp://qastaging/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_test into lp://qastaging/ubuntu-autopilot-tests/ubuntu-experience-tests

contacts_dbus_test
Merge into ubuntu-experience-tests

Proposed by Brendan Donegan on 2014-06-24

Status:

Superseded

Proposed branch:

lp://qastaging/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_test

Merge into:

lp://qastaging/ubuntu-autopilot-tests/ubuntu-experience-tests

Diff against target:

191 lines (+125/-16)

3 files modified

debian/control (+2/-0)
tests/test_helpers.py (+111/-0)
ubuntu_experience_tests/helpers.py (+12/-16)

To merge this branch:

bzr merge lp://qastaging/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_test

Critical

In Progress

Link a bug report

Reviewer	Review Type	Date Requested	Status
Leo Arias (community)		2014-06-24	Approve on 2014-07-03
PS Jenkins bot	continuous-integration		Needs Fixing on 2014-07-02
Review via email: mp+224321@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2014-07-04.

Commit message

Unit tests for ContactsDbusService

Description of the change

Add some unit tests for ContactsDBusService. Also simplify get_vcard_uid and allow it to handle all newlines, not just CRLF newlines.

Revision history for this message

Leo Arias (elopio) on 2014-06-27:

review: Needs Fixing (code review)

Revision history for this message

Brendan Donegan (brendan-donegan) wrote on 2014-06-27:

see my comments, i'll update the rest later

Revision history for this message

Leo Arias (elopio) on 2014-06-27:

lp://qastaging/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_test updated on 2014-06-30

28. By Brendan Donegan on 2014-06-30: flake8 fixes
29. By Brendan Donegan on 2014-06-30: Use addCleanup instead of tearDown

Revision history for this message

Brendan Donegan (brendan-donegan) wrote on 2014-06-30:

So how about getting this merged and then we can move it to address-book-app ;)

Revision history for this message

Leo Arias (elopio) on 2014-06-30:

review: Needs Fixing

lp://qastaging/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_test updated on 2014-06-30

30. By Brendan Donegan on 2014-06-30: Pass callables in addCleanup

Revision history for this message

Brendan Donegan (brendan-donegan) wrote on 2014-06-30:

That's correct - whoops

Revision history for this message

Leo Arias (elopio) wrote on 2014-07-01:

One more detail, the new deps on debian/control are missing the commas to separate them.

Please run bzr bd to make sure that the package still builds.
Francis has this half automated to get jenkins running it for us.

review: Needs Fixing

Revision history for this message

Leo Arias (elopio) on 2014-07-01:

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-01:

FAILED: Continuous integration, rev:30
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_test/+merge/224321/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/6/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1429/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/6/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/6/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/6/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2384/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/6/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_test updated on 2014-07-02

31. By Brendan Donegan on 2014-07-02: Fix control file and flake8 error in helpers.py

Revision history for this message

Brendan Donegan (brendan-donegan) wrote on 2014-07-02:

Ran bzr bd and built succesfully

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-02:

FAILED: Continuous integration, rev:31
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_test/+merge/224321/+edit-commit-message

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/8/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-02:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/9/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Leo Arias (elopio) wrote on 2014-07-03:

There seems to be a problem with the packaging. I'll take a look.
Your code looks good, thanks.
Please move it to address book app or address book service as soon as possible.

review: Approve

lp://qastaging/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_test updated on 2014-07-04

32. By Brendan Donegan on 2014-07-04: Run unit tests during builds and update test code to run under python3. Also revert the addCleanup change as it's not working
33. By Brendan Donegan on 2014-07-04: Use nose to run the tests instead
34. By Brendan Donegan on 2014-07-04: Merged from trunk

Unmerged revisions

34. By Brendan Donegan on 2014-07-04: Merged from trunk
33. By Brendan Donegan on 2014-07-04: Use nose to run the tests instead
32. By Brendan Donegan on 2014-07-04: Run unit tests during builds and update test code to run under python3. Also revert the addCleanup change as it's not working
31. By Brendan Donegan on 2014-07-02: Fix control file and flake8 error in helpers.py
30. By Brendan Donegan on 2014-06-30: Pass callables in addCleanup
29. By Brendan Donegan on 2014-06-30: Use addCleanup instead of tearDown
28. By Brendan Donegan on 2014-06-30: flake8 fixes
27. By Brendan Donegan on 2014-06-24: Add python3-dbus and python3-dbusmock to Build-Deps
26. By Brendan Donegan on 2014-06-24: Found a better home for the unit tests
25. By Brendan Donegan on 2014-06-24: Add unit tests for ContactsDbusService

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Brendan Donegan

Leo Arias

Ubuntu Testcase Admins