Merge lp://qastaging/~brian-murray/mago/jockey-deactivate-test into lp://qastaging/~mago-contributors/mago/mago-testsuite

Proposed by Brian Murray
Status: Merged
Merged at revision: 14
Proposed branch: lp://qastaging/~brian-murray/mago/jockey-deactivate-test
Merge into: lp://qastaging/~mago-contributors/mago/mago-testsuite
Diff against target: 37 lines (+15/-2)
1 file modified
jockey-gtk/test_jockey-gtk.py (+15/-2)
To merge this branch: bzr merge lp://qastaging/~brian-murray/mago/jockey-deactivate-test
Reviewer Review Type Date Requested Status
Jean-Baptiste Lallement Approve
Nagappan Alagappan Approve
Review via email: mp+47618@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Nagappan Alagappan (nagappan) wrote :

Maybe the hard coded label moved above and we can use just the variable. If the label changes later or we are planing i18n / l10n testing later, we can just change the variable value and we are all set.

Thanks

review: Approve
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Just for reference the LDTP way to check is an object exist are ldtp.objectexist() or ldtp.guiexist() which also check for the existence of the window.
Anyway, this is a bitesize change, I'll merge your fix and update it.

Thanks much.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches