Merge ~brian-murray/ubuntu-release-upgrader:python-dbg-fix into ubuntu-release-upgrader:ubuntu/master
| Status: | Merged |
|---|---|
| Merged at revision: | 1229ab6c7893bfb17609cbab4dcfa1672763c682 |
| Proposed branch: | ~brian-murray/ubuntu-release-upgrader:python-dbg-fix |
| Merge into: | ubuntu-release-upgrader:ubuntu/master |
| Diff against target: |
69 lines (+30/-19) 2 files modified
DistUpgrade/DistUpgradeQuirks.py (+23/-19) debian/changelog (+7/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Dimitri John Ledkov | Pending | ||
| Lukas Märdian | Pending | ||
| Ubuntu Core Development Team | Pending | ||
|
Review via email:
|
|||
Description of the change
The fix for bug 1875523 does not resolve failures to calculate upgrades for people who have python-dbg installed on Ubuntu 18.04 LTS. This was discovered when investigating bug 1887544 and a minimal test case can be created by just installing python-pyqt5-dbg and then trying to upgrade to Ubuntu 20.04 LTS. By replacing python-dbg with python2-dbg the upgrade can proceed.
Here's a portion of the an upgrade I did from 18.04 LTS w/ python-pyqt5-dbg installed to Ubuntu 20.04 LTS.
2020-07-31 09:45:21,140 DEBUG quirks: running PreDistUpgradeCache
2020-07-31 09:45:21,140 DEBUG running Quirks.
2020-07-31 09:45:21,140 INFO checking for python-dbg
2020-07-31 09:45:21,140 INFO installing python2-dbg because python-dbg was installed
2020-07-31 09:45:21,140 DEBUG Installing 'python2-dbg' (python-dbg was installed on the system)
2020-07-31 09:45:21,282 INFO removing python-dbg because python2-dbg is being installed
2020-07-31 09:45:21,282 DEBUG Removing 'python-dbg' (python2-dbg is being installed on the system)
2020-07-31 09:45:21,282 INFO failed to remove python-dbg
2020-07-31 09:45:21,283 INFO checking for python-minimal
2020-07-31 09:45:21,283 INFO installing python-is-python2 because python-minimal was installed
2020-07-31 09:45:21,283 DEBUG Installing 'python-is-python2' (python-minimal was installed on the system)
2020-07-31 09:45:21,300 INFO removing python-minimal because python-is-python2 is being installed
2020-07-31 09:45:21,300 DEBUG Removing 'python-minimal' (python-is-python2 is being installed on the system)
2020-07-31 09:45:21,300 INFO failed to remove python-minimal
While the log file says the packages failed to remove (which I just noticed) they did end up being removed.
2020-07-31 09:45:26,664 DEBUG Remove: fwupdate-signed gnome-settings-
So I think this change is okay but I'd appreciate a second opinion.
| Dimitri John Ledkov (xnox) wrote | # |
| Lukas Märdian (slyon) wrote | # |
| Brian Murray (brian-murray) wrote | # |
| Dimitri John Ledkov (xnox) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
python-dev => python2-dev
libpython-dev => libpython2-dev
libpython-stdlib => libpython2-stdlib
python-doc => python2-doc
libpython-dbg => libpython2-dbg
will probably need transitions too. However, i'm not sure if we should be explicitely installing the new ones, or like allow for them to be pullsed in via dependencies.