Merge lp://qastaging/~brian.curtin/ubuntuone-client/upoad-spellcheck into lp://qastaging/ubuntuone-client

Proposed by Brian Curtin
Status: Work in progress
Proposed branch: lp://qastaging/~brian.curtin/ubuntuone-client/upoad-spellcheck
Merge into: lp://qastaging/ubuntuone-client
Diff against target: 46 lines (+16/-2)
2 files modified
ubuntuone/syncdaemon/interaction_interfaces.py (+1/-1)
ubuntuone/syncdaemon/tunnel_runner.py (+15/-1)
To merge this branch: bzr merge lp://qastaging/~brian.curtin/ubuntuone-client/upoad-spellcheck
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Needs Fixing
dobey (community) Approve
Review via email: mp+97656@code.qastaging.launchpad.net

Commit message

Correct spelling of "upload" (from "upoad") in a keyword argument.

Description of the change

Spelling change on keyword argument: upoad to upLoad

FWIW, nothing seems affected by this change when running the tests. I just noticed the spelling error and fixed it since it's actually in usable code.

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Brian,

can you please add a test that will fail with this typo?

Thanks a lot!

review: Needs Fixing
1209. By Brian Curtin

Give reactor.spawnProcess a process_path and args that will work on win32

1210. By Brian Curtin

Put TUNNEL_EXECUTABLE back in so Linux doesn't break

Unmerged revisions

1210. By Brian Curtin

Put TUNNEL_EXECUTABLE back in so Linux doesn't break

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches