Drizzle

Merge lp://qastaging/~brianaker/drizzle/pid-file-fix into lp://qastaging/~drizzle-trunk/drizzle/development

  1. pid-file-fix
  2. Merge into development
Proposed by Brian Aker
Status: Merged
Approved by: Brian Aker
Approved revision: 2528
Merged at revision: 2532
Proposed branch: lp://qastaging/~brianaker/drizzle/pid-file-fix
Merge into: lp://qastaging/~drizzle-trunk/drizzle/development
Diff against target: 372 lines (+102/-71)
3 files modified
drizzled/drizzled.cc (+88/-30)
drizzled/main.cc (+5/-3)
plugin/signal_handler/signal_handler.cc (+9/-38)
To merge this branch: bzr merge lp://qastaging/~brianaker/drizzle/pid-file-fix
Reviewer Review Type Date Requested Status
Olaf van der Spek (community) Needs Fixing
Drizzle Merge Team Pending
Review via email: mp+98081@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Olaf van der Spek (olafvdspek) wrote :

Looks like the bug fix is mixed with lots of unrelated changes. Why are you changing not X to X == false?
And why do close(file) twice if the first one fails?

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.