Merge lp://qastaging/~brianaker/libdrizzle/bootstrap-update-april-2013 into lp://qastaging/libdrizzle

Proposed by Brian Aker
Status: Merged
Approved by: Andrew Hutchings
Approved revision: 121
Merged at revision: 121
Proposed branch: lp://qastaging/~brianaker/libdrizzle/bootstrap-update-april-2013
Merge into: lp://qastaging/libdrizzle
Diff against target: 1208 lines (+475/-152)
3 files modified
bootstrap.sh (+358/-127)
configure.ac (+3/-0)
m4/ax_harden_compiler_flags.m4 (+114/-25)
To merge this branch: bzr merge lp://qastaging/~brianaker/libdrizzle/bootstrap-update-april-2013
Reviewer Review Type Date Requested Status
Andrew Hutchings Approve
Review via email: mp+161265@code.qastaging.launchpad.net

Description of the change

Update bootstrap and hardening files.

To post a comment you must log in.
Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

Lots of really good stuff in there, many thanks :)

Thanks for moving --param=ssp-buffer-size somewhere better. Clang 3.2 was barfing on that but autotools wasn't picking that up in the support check due to the message it generates.

review: Approve
Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

so, we have 2 problems found by the RHEL builder:

1. it appears to be a lot stricter than before (and stricter than the other builders) and firing lots of warnings

2. the test suite is now executing on that builder and is having connect timeouts which isn't a SKIP event we test for. I'm hoping this isn't a bug :/

https://jenkins.drizzle.org/job/libdrizzle-build-matrix/label=amd64-RedHatEnterpriseServer-6.4/102/console

I'll look at #1 at some point today (going to download CentOS first to try this out)

Revision history for this message
Brian Aker (brianaker) wrote :

I can take a look as well. I've had to remove reachable for other
projects because of the glibc issue for the resolver.

Sent from my Ti85

On Apr 27, 2013, at 0:15, Andrew Hutchings <email address hidden> wrote:

> so, we have 2 problems found by the RHEL builder:
>
> 1. it appears to be a lot stricter than before (and stricter than the other builders) and firing lots of warnings
>
> 2. the test suite is now executing on that builder and is having connect timeouts which isn't a SKIP event we test for. I'm hoping this isn't a bug :/
>
> https://jenkins.drizzle.org/job/libdrizzle-build-matrix/label=amd64-RedHatEnterpriseServer-6.4/102/console
>
> I'll look at #1 at some point today (going to download CentOS first to try this out)
> --
> https://code.launchpad.net/~brianaker/libdrizzle/bootstrap-update-april-2013/+merge/161265
> You are the owner of lp:~brianaker/libdrizzle/bootstrap-update-april-2013.

122. By Brian Aker

Update bootstrap and disable two warning types that currently are not passable.

Revision history for this message
Brian Aker (brianaker) wrote :

I am commenting out style and effc for the moment.

effc is showing a few real bugs (init issues).

Cheers,
 -Brian

On Apr 26, 2013, at 11:59 PM, Andrew Hutchings <email address hidden> wrote:

> The proposal to merge lp:~brianaker/libdrizzle/bootstrap-update-april-2013 into lp:libdrizzle has been updated.
>
> Status: Needs review => Approved
>
> For more details, see:
> https://code.launchpad.net/~brianaker/libdrizzle/bootstrap-update-april-2013/+merge/161265
> --
> https://code.launchpad.net/~brianaker/libdrizzle/bootstrap-update-april-2013/+merge/161265
> You are the owner of lp:~brianaker/libdrizzle/bootstrap-update-april-2013.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: