Merge lp://qastaging/~brianaker/libdrizzle/non-block-fix into lp://qastaging/libdrizzle

Proposed by Brian Aker
Status: Merged
Approved by: Andrew Hutchings
Approved revision: 73
Merged at revision: 73
Proposed branch: lp://qastaging/~brianaker/libdrizzle/non-block-fix
Merge into: lp://qastaging/libdrizzle
Diff against target: 1377 lines (+515/-367)
20 files modified
libdrizzle-5.1/constants.h (+2/-1)
libdrizzle-5.1/drizzle.h (+8/-0)
libdrizzle-5.1/error.h (+1/-1)
libdrizzle-5.1/include.am (+0/-1)
libdrizzle-5.1/structs.h (+0/-17)
libdrizzle/common.h (+6/-6)
libdrizzle/conn.cc (+245/-179)
libdrizzle/datetime.h (+52/-0)
libdrizzle/drizzle.cc (+6/-7)
libdrizzle/include.am (+2/-0)
libdrizzle/pack.h (+3/-10)
libdrizzle/structs.h (+5/-0)
tests/unit/binlog.c (+12/-8)
tests/unit/column.c (+24/-10)
tests/unit/connect.c (+14/-15)
tests/unit/insert_id.c (+21/-5)
tests/unit/query.c (+27/-22)
tests/unit/row.c (+27/-22)
tests/unit/statement.c (+33/-41)
tests/unit/unbuffered_query.c (+27/-22)
To merge this branch: bzr merge lp://qastaging/~brianaker/libdrizzle/non-block-fix
Reviewer Review Type Date Requested Status
Andrew Hutchings Approve
Review via email: mp+141474@code.qastaging.launchpad.net

Description of the change

This updates more of the tests to yatl lite. If MySQL or Drizzle are available it will use them.

This also solves many corner cases around NON Block. We still hit recv() too often.

pack functions and the datetime structure are now private.

To post a comment you must log in.
Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

Currently the user needs the public date/time struct. But I've figured out a way of doing that much better. So Approve! many thanks for this :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: