Compiz

Merge lp://qastaging/~bryanfritt/compiz/more_ezoom_and_100percent_grid into lp://qastaging/compiz/0.9.13

more_ezoom_and_100percent_grid
Merge into 0.9.13

Proposed by BryanFRitt on 2016-07-14

Status:

Merged

Approved by:

Marco Trevisan (Treviño) on 2016-07-26

Approved revision:

4059

Merged at revision:

4075

Proposed branch:

lp://qastaging/~bryanfritt/compiz/more_ezoom_and_100percent_grid

Merge into:

lp://qastaging/compiz/0.9.13

Diff against target:

627 lines (+408/-116)

4 files modified

plugins/ezoom/ezoom.xml.in (+191/-22)
plugins/ezoom/src/ezoom.cpp (+110/-20)
plugins/ezoom/src/ezoom.h (+16/-3)
plugins/grid/src/grid.cpp (+91/-71)

To merge this branch:

bzr merge lp://qastaging/~bryanfritt/compiz/more_ezoom_and_100percent_grid

Related bugs:

Bug #1201061: There should be more zoom levels in 'Specific Zoom'.	Wishlist	Fix Released
Bug #1591737: The 'Grid' plugin should include 100% widths in it's 'Cycle Through Multiple Sizes'.	Undecided	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Compiz Maintainers		2016-07-14	Pending
Review via email: mp+300099@code.qastaging.launchpad.net

Commit message

Added in 100% to Grid's 'Cycle Through Multiple Sizes' and
Added in more 'Specific Zoom' levels to eZoom

Description of the change

Added in 100% to Grid's 'Cycle Through Multiple Sizes' and
Added in more 'Specific Zoom' levels to eZoom

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2016-07-20:

A part from some indentation issues (annoying, I know, but we've to follow what the ancestors did here), I think is fine.

So please, fix them and we can land it.

Revision history for this message

BryanFRitt (bryanfritt) wrote on 2016-07-26:

"A part from some indentation issues (annoying, I know, but we've to follow what the ancestors did here), I think is fine.

So please, fix them and we can land it."

Somehow I missed this message. Was this about an earlier version? I modified the indentation to match back before I resubmitted this for 0.9.13. "4055. By BryanFRitt on 2016-07-01"*. If this was done improperly or missed something let me know how it needs to be changed and I can change it.

*
4055. By BryanFRitt on 2016-07-01

reformated changed lines using the "Compiz Development/ CodingStyle"
http://wiki.compiz.org/Development/CodingStyle

lp://qastaging/~bryanfritt/compiz/more_ezoom_and_100percent_grid updated on 2016-07-28