Actual change:
- ack to move the systemd check to a function
I needed some time for "APACHE_STARTED_BY_SYSTEMD".
That is set in the environment by the .service files.
So I assume if APACHE_STARTED_BY_SYSTEMD isn't set we probe (the new function).
But if it is set, then we exit 1 which means "no need for systemd"
is that
a) to unbreak loops where we start this from systemd, starting systemd, starting systemd, ...
Then it makes sense but I wanted to ask ito be sure
b) wrong and should actually "exit 0" if APACHE_STARTED_BY_SYSTEMD is set?
Further in the change there is some whitespace damage with the "exit" calls not using spaces but tabs.
If you could fix the latter and explain the former then this should be fine to go.
SRU Template - LGTM
Changelog - LGTM
Actual change:
- ack to move the systemd check to a function
I needed some time for "APACHE_ STARTED_ BY_SYSTEMD" . STARTED_ BY_SYSTEMD isn't set we probe (the new function).
That is set in the environment by the .service files.
So I assume if APACHE_
But if it is set, then we exit 1 which means "no need for systemd"
is that STARTED_ BY_SYSTEMD is set?
a) to unbreak loops where we start this from systemd, starting systemd, starting systemd, ...
Then it makes sense but I wanted to ask ito be sure
b) wrong and should actually "exit 0" if APACHE_
Further in the change there is some whitespace damage with the "exit" calls not using spaces but tabs.
If you could fix the latter and explain the former then this should be fine to go.