Ubuntu
apache2 package

Merge ~bryce/ubuntu/+source/apache2:sru-lp1832182-graceful-focal into ubuntu/+source/apache2:ubuntu/focal-devel

  1. Git
  2. lp:~bryce/ubuntu/+source/apache2
  3. sru-lp1832182-graceful-focal
  4. Merge into ubuntu/focal-devel
Proposed by Bryce Harrington
Status: Merged
Approved by: Bryce Harrington
Approved revision: 18974f5ac421332648b982f4f97bade9dc3fc480
Merge reported by: Christian Ehrhardt 
Merged at revision: 18974f5ac421332648b982f4f97bade9dc3fc480
Proposed branch: ~bryce/ubuntu/+source/apache2:sru-lp1832182-graceful-focal
Merge into: ubuntu/+source/apache2:ubuntu/focal-devel
Diff against target: 98 lines (+40/-18)
2 files modified
debian/apache2ctl (+30/-18)
debian/changelog (+10/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
git-ubuntu developers Pending
Canonical Server Pending
Review via email: mp+393677@code.qastaging.launchpad.net

Description of the change

Backport to focal of fix from
https://code.launchpad.net/~bryce/ubuntu/+source/apache2/+git/apache2/+merge/393426

The start command was updated to work with systemd earlier; this extends the same fix for the 'graceful' command.

PPA: https://launchpad.net/~bryce/+archive/ubuntu/apache2-sru-lp1832182
SRU: https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1832182
Forwarded to Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=927302

To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

As reference, that old fix for start was at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=852543 in pkg/import/2.4.25-3

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I remember reviewing the same fix for another release.
This one still LGTM and makes sense to avoid the direct restart breaking status detection.

Also changelog and version are ok.

The only thing I didn't get to this time is testing, have you run your PPA through upgrade tests already?

review: Approve
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

To keep discussions in one place also see https://code.launchpad.net/~bryce/ubuntu/+source/apache2/+git/apache2/+merge/393680/comments/1036493

review: Needs Information
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Approved per discussion in the groovy MP

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Sounds good, I've tagged, pushed, and uploaded this.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches