Ubuntu
apache2 package

Code review comment for ~bryce/ubuntu/+source/apache2:sru-lp1832182-graceful-groovy

  1. Git
  2. lp:~bryce/ubuntu/+source/apache2
  3. sru-lp1832182-graceful-groovy
  4. Merge into ubuntu/groovy-devel
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Actually on the SRU I have one more thought.
A formerly "silent" action like the graceful restart does now emit messages:

  echo "Invoking 'systemctl restart ${APACHE_SYSTEMD_SERVICE}'."
  echo "Use 'systemctl status ${APACHE_SYSTEMD_SERVICE}' for more info."

I agree this is good going forward and also good for "humans" to understand what might happen.
But on an SRU context I'm slightly more concerned people might grep output or such.
I don't have a much better idea yet, maybe pushing the messages to the log (less obvious to be seen, but less potential disruption)?
What do you think?

review: Needs Information

« Back to merge proposal