Ubuntu theme

Merge lp://qastaging/~c-lobrano/ubuntu-themes/increase-window-control-buttons-size into lp://qastaging/ubuntu-themes

  1. increase-window-control-buttons-size
  2. Merge into trunk
Proposed by Carlo Lobrano
Status: Needs review
Proposed branch: lp://qastaging/~c-lobrano/ubuntu-themes/increase-window-control-buttons-size
Merge into: lp://qastaging/ubuntu-themes
Diff against target: 225 lines (+32/-48)
2 files modified
Ambiance/gtk-3.20/gtk-widgets.css (+16/-24)
Radiance/gtk-3.20/gtk-widgets.css (+16/-24)
To merge this branch: bzr merge lp://qastaging/~c-lobrano/ubuntu-themes/increase-window-control-buttons-size
Reviewer Review Type Date Requested Status
Daniel van Vugt Needs Information
Ubuntu Artwork Packagers Pending
Review via email: mp+342898@code.qastaging.launchpad.net

Commit message

Ambiance, Radiance: increased window control buttons size

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Doesn't this change the button spacing rather than the visible size?

If it's only the former then this proposal should not be linked to bug 1693609.

Reply
Revision history for this message
Daniel van Vugt (vanvugt) :
review: Needs Information
Reply
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

It might help to link to screenshots so people don't have to go to as much effort to review this.

Reply
Revision history for this message
Carlo Lobrano (c-lobrano) wrote :

> Doesn't this change the button spacing rather than the visible size?

Yes it changes also the visible size, since it uses only button images with size > 2

Here is a picture of the result

https://www.dropbox.com/s/ir0ufzup0bp5nhn/ut-window-control-buttons.png?dl=0

Reply
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

I would not change this for now (as I'm not totally convinced and being bast UIF).

Also, in this case the way of doing it, instead of changing the PNGs would be to regenerate them at proper size.

You can use a script like the one at https://code.launchpad.net/~3v1n0/ubuntu-themes/windowbuttons-bg-and-padding/+merge/342171

Reply
Revision history for this message
Carlo Lobrano (c-lobrano) wrote :

Understood, and thanks for the script!

Reply

Unmerged revisions

617. By Carlo Lobrano

Ambiance, Radiance: increased window control buttons size

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches