Merge lp://qastaging/~c-lobrano/ubuntu-themes/pathbar-review into lp://qastaging/ubuntu-themes

Proposed by Carlo Lobrano
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 621
Merged at revision: 622
Proposed branch: lp://qastaging/~c-lobrano/ubuntu-themes/pathbar-review
Merge into: lp://qastaging/ubuntu-themes
Diff against target: 186 lines (+91/-20)
3 files modified
Ambiance/gtk-3.20/gtk-widgets.css (+44/-12)
Radiance/gtk-3.20/gtk-widgets-radiance.css (+1/-2)
Radiance/gtk-3.20/gtk-widgets.css (+46/-6)
To merge this branch: bzr merge lp://qastaging/~c-lobrano/ubuntu-themes/pathbar-review
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+342836@code.qastaging.launchpad.net

Commit message

Ambiance, Radiance: Review of pathbar and stackswitcher buttons

In order to solve inconsistencies in Nautilus Path bar and in stackswitcher buttons:

Changed checked state:
- from background color change to light "3D pressed button effect"

Changed disabled state: background is now the same as enabled button, but
- label is dimmed (as it was before)
- borders are dimmed

Change proposed and designed at https://github.com/CanonicalLtd/desktop-design/issues/28

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Couple of things here:
 1. Maybe a bit more inner shadow would be nicer, but not sure... There was some discussion already in github, but maybe somethin more closer to the mockup
 2. Could you provide an .svg too for the generated borders .png?

Cheers

Revision history for this message
Carlo Lobrano (c-lobrano) wrote :

Hi Marco,

right, I misunderstood the discussion on github, I'll increase the shadow.
About the borders, do you need both .svg and .png, is that right? Which one will be used?

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

PNGs have to be used, but the .svg should be included in the source code in case we need to edit it quickly or in case we need to regenerate it for bigger scaling.

Revision history for this message
Carlo Lobrano (c-lobrano) wrote :

At this link there are some variations I tried

https://paper.dropbox.com/doc/UT-pathbar-XbMB0Y4jGlv0YgKfOlw09

It is a full list of the attempts I tracked, so the firsts are probably not what you meant, but the last 3 might

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :
Revision history for this message
Carlo Lobrano (c-lobrano) wrote :

Hi Trevinho, sorry for the late reply. I should be able to check it on
Thursday, hope it is not too late

Il lun 16 apr 2018, 23:01 Marco Trevisan (Treviño) <mail@3v1n0.net> ha
scritto:

> I guess this is the best compromise:
>
>
> https://photos-6.dropbox.com/t/2/AAC_6sGju6e4ivZWkTfAiMyMRrbxxHkox8ZCimGaOVpnkQ/12/489501/png/2048x1/5/1523926800/0/10/image.png/_/png%2520https%253A%252F%252Fd2mxuefqeaa7sj.cloudfront.net%252Fs_68309CEF1ACE56932BF20E99D6B8C0AA9D907E677135141F9D2031A1C215D473_1523392306594_file.png
>
> The 6th from the start (commented there too).
>
> Any chance for the .svg's? Anyway I'd prefer to land this this week... :)
> --
>
> https://code.launchpad.net/~c-lobrano/ubuntu-themes/pathbar-review/+merge/342836
> You are the owner of lp:~c-lobrano/ubuntu-themes/pathbar-review.
>

621. By Carlo Lobrano

Ambiance, Radiance: updated pressed effect according to code review

Revision history for this message
Carlo Lobrano (c-lobrano) wrote :

Updated .css of Ambiance and Radiance with proposed mockup, but I need to ask for help about svg. I tried with both inkscape and online converters but the result was not good

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ok, that's fine for now... How these png where generated though?

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Anyway speaking of the fix itself I think it's a good improvement, so let's go with this.

If we can have someone to create SVGs also would be cool (there are already svg borders in the source code that can be reused).

Cheers

review: Approve
Revision history for this message
Carlo Lobrano (c-lobrano) wrote :

> How these png where generated though?

I think Mads started from other png

> If we can have someone to create SVGs also would be cool (there are already svg borders in the source code that can be reused).

I will look at that, thank you :)

Revision history for this message
MadsRH (madsrh) wrote :

> ...there are already svg borders in the source code that can be reused

@Marco Trevisan could you point me to the SVG? Should this be located in the gtk-3.0 assets folder?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches