Thanks for taking on this bug. I've added some comments, but none that you really need to address in this branch.
What I *do* think needs fixing before this can land is... tests! Can you please add a test for the bug? As Steve pointed out in my own branch, the best way to ensure this fixes the problem is to apply the test-adding diff, see the test fail, then add the fix and see it succeed.
The change looks okay on the face of it, but please add a test.
Thanks for taking on this bug. I've added some comments, but none that you really need to address in this branch.
What I *do* think needs fixing before this can land is... tests! Can you please add a test for the bug? As Steve pointed out in my own branch, the best way to ensure this fixes the problem is to apply the test-adding diff, see the test fail, then add the fix and see it succeed.
The change looks okay on the face of it, but please add a test.