Merge lp://qastaging/~camptocamp/account-consolidation/fix-domain-nbi into lp://qastaging/~account-core-editors/account-consolidation/7.0
Proposed by
Nicolas Bessi - Camptocamp
| Status: | Merged |
|---|---|
| Merged at revision: | 21 |
| Proposed branch: | lp://qastaging/~camptocamp/account-consolidation/fix-domain-nbi |
| Merge into: | lp://qastaging/~account-core-editors/account-consolidation/7.0 |
| Diff against target: |
12 lines (+2/-1) 1 file modified
account_consolidation/account_move_line.py (+2/-1) |
| To merge this branch: | bzr merge lp://qastaging/~camptocamp/account-consolidation/fix-domain-nbi |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Yannick Vaucher @ Camptocamp | Approve | ||
| Leonardo Pistone | Approve | ||
|
Review via email:
|
|||
Description of the change
[FIX] doamin on function fields that can badly impact performance
To post a comment you must log in.
Revision history for this message
| Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
On a low-level, I see that elements of curr_ids that are not in ids should not change the result. So I approve the fix.
On the other hand, I don't get what the method does. Could you take the occasion to add a docstring or comment, and maybe rename tid, ids, curr_ids ...
thanks!